From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Andrew Pinski <pinskia@gmail.com>,
Sasha Levin <sasha.levin@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: use the gnu89 standard explicitly
Date: Mon, 20 Oct 2014 02:21:24 +0300 [thread overview]
Message-ID: <20141019232124.GC9319@node.dhcp.inet.fi> (raw)
In-Reply-To: <20141019231031.GB9319@node.dhcp.inet.fi>
On Mon, Oct 20, 2014 at 02:10:31AM +0300, Kirill A. Shutemov wrote:
> On Sun, Oct 19, 2014 at 04:05:25PM -0700, Linus Torvalds wrote:
> > On Sun, Oct 19, 2014 at 2:03 PM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> > >
> > > Here's one example how it fails: http://marc.info/?l=gcc&m=141349914632010&w=2
> >
> > Ok, that just looks like a gnu11 bug, then. Not being able to
> > initialize structures because some sub-structure has a volatile member
> > is just pure BS.
> >
> > Has anybody reported this as a gcc bug? That email may be on the gcc
> > list, but I'm not seeing anybody acknowledge it as a bug..
> >
> > I cannot imagine that anybody sane claims that this is *wanted*
> > behavior from "gnu11".
>
> IIUC, it's nothing to do with volatile. C11 and above reads
s/C11/C99/
>
> (rwlock_t) { .raw_lock = { 0 }, }
>
> as compound literal (which is not constant) rather than constant
> initalizer plus a cast.
In some places we can just drop the cast, but it doesn't work everywhere.
I don't see a way to get pre-c99 semantics here.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2014-10-19 23:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 16:07 [PATCH] kernel: use the gnu89 standard explicitly Sasha Levin
2014-10-19 20:05 ` Linus Torvalds
2014-10-19 20:23 ` Joe Perches
[not found] ` <CA+55aFwbq4TtQXC9PTjOF3UPP7u8XH1mSYjvT7pevKcQBfy25A@mail.gmail.com>
2014-10-19 21:31 ` Joe Perches
2014-10-19 21:03 ` Aaro Koskinen
2014-10-19 23:05 ` Linus Torvalds
2014-10-19 23:10 ` Kirill A. Shutemov
2014-10-19 23:19 ` Al Viro
2014-10-19 23:21 ` Kirill A. Shutemov [this message]
2014-10-19 23:26 ` Al Viro
2014-10-19 23:49 ` Linus Torvalds
2014-10-19 23:59 ` Sasha Levin
2014-10-20 0:23 ` Linus Torvalds
2014-10-20 4:16 ` Al Viro
2014-10-19 23:25 ` pinskia
2014-10-19 23:52 ` Sasha Levin
2014-10-19 22:29 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019232124.GC9319@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=aaro.koskinen@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pinskia@gmail.com \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).