From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tejun Heo <tj@kernel.org>, David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: + oom-pm-oom-killed-task-cannot-escape-pm-suspend.patch added to -mm tree
Date: Mon, 20 Oct 2014 21:06:20 +0200 [thread overview]
Message-ID: <20141020190620.GA21882@redhat.com> (raw)
In-Reply-To: <20141020184657.GA505@dhcp22.suse.cz>
On 10/20, Michal Hocko wrote:
>
> On Fri 17-10-14 19:19:04, Oleg Nesterov wrote:
> > > @@ -504,11 +516,13 @@ void oom_kill_process(struct task_struct
> > > pr_err("Kill process %d (%s) sharing same memory\n",
> > > task_pid_nr(p), p->comm);
> > > task_unlock(p);
> > > + atomic_inc(&oom_kills);
> >
> > Do we really need this? Can't freeze_processes() (ab)use oom_notify_list?
>
> I would really prefer not using oom_notify_list. It is just an ugly
> interface.
And to me oom_kills_count() is more ugly ;) But! of course this is
subjective, I am not going to insist.
> Reduce the race window by checking all tasks after OOM killer has been
> disabled. This is still not race free
Yes, thanks.
I only argued because this fact was not documented. And I agree that it
is hardly possible to close this race, and this patch makes the things
better.
I think this version is fine.
Oleg.
next prev parent reply other threads:[~2014-10-20 19:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 17:19 + oom-pm-oom-killed-task-cannot-escape-pm-suspend.patch added to -mm tree Oleg Nesterov
2014-10-20 18:46 ` Michal Hocko
2014-10-20 19:06 ` Oleg Nesterov [this message]
2014-10-20 19:56 ` oom && coredump Oleg Nesterov
2014-11-27 12:29 ` Michal Hocko
2014-11-27 17:47 ` Oleg Nesterov
2014-12-02 8:59 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020190620.GA21882@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=tj@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).