From: Mike Frysinger <vapier@gentoo.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] binfmt_misc: add comments & debug logs
Date: Mon, 20 Oct 2014 18:37:22 -0400 [thread overview]
Message-ID: <20141020223722.GA15168@vapier> (raw)
In-Reply-To: <1413765718.7076.3.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On 19 Oct 2014 17:41, Joe Perches wrote:
> On Sun, 2014-10-19 at 19:03 -0400, Mike Frysinger wrote:
> > let's deploy extensive pr_debug markers at
> > logical parse points, and add comments to the dense parsing logic.
> []
> > diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
> []
> > @@ -259,14 +270,17 @@ static char * check_special_flags (char * sfs, Node * e)
> > while (cont) {
> > switch (*p) {
> > case 'P':
> > + pr_debug("register: flag: P (preserve argv0)");
>
> Missing '\n' newline.
> Can you please add them as appropriate?
hmm, guess i was relying on pr_cont behavior to do the right thing. will do.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-20 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 23:03 [PATCH 1/2] binfmt_misc: add comments & debug logs Mike Frysinger
2014-10-19 23:03 ` [PATCH 2/2] binfmt_misc: clean up code style a bit Mike Frysinger
2014-10-20 0:41 ` [PATCH 1/2] binfmt_misc: add comments & debug logs Joe Perches
2014-10-20 22:37 ` Mike Frysinger [this message]
2014-10-20 22:45 ` [PATCH 1/2 v2] " Mike Frysinger
2014-10-20 22:46 ` [PATCH 2/2 v2] binfmt_misc: clean up code style a bit Mike Frysinger
2014-10-20 22:59 ` [PATCH 1/2 v2] binfmt_misc: add comments & debug logs Joe Perches
2014-10-20 23:54 ` Mike Frysinger
2014-10-28 22:58 ` Andrew Morton
2014-10-28 23:25 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020223722.GA15168@vapier \
--to=vapier@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).