From: Jiri Olsa <jolsa@redhat.com>
To: Kan Liang <kan.liang@intel.com>
Cc: a.p.zijlstra@chello.nl, eranian@google.com,
linux-kernel@vger.kernel.org, mingo@redhat.com, paulus@samba.org,
acme@kernel.org, ak@linux.intel.com
Subject: Re: [PATCH V6 17/17] perf tools: choose to dump callchain from LBR and FP
Date: Fri, 24 Oct 2014 15:36:01 +0200 [thread overview]
Message-ID: <20141024133600.GC1036@krava.brq.redhat.com> (raw)
In-Reply-To: <1413755712-8259-18-git-send-email-kan.liang@intel.com>
On Sun, Oct 19, 2014 at 05:55:12PM -0400, Kan Liang wrote:
SNIP
> - return 0;
> - }
> - continue;
> + mix_chain_nr = i + 2 + lbr_nr;
> + if (mix_chain_nr > PERF_MAX_STACK_DEPTH) {
> + pr_warning("corrupted callchain. skipping...\n");
> + return 0;
> }
>
> - al.filtered = 0;
> - thread__find_addr_location(thread, machine, cpumode,
> - MAP__FUNCTION, ip, &al);
> - if (al.sym != NULL) {
> - if (sort__has_parent && !*parent &&
> - symbol__match_regex(al.sym, &parent_regex))
> - *parent = al.sym;
> - else if (have_ignore_callees && root_al &&
> - symbol__match_regex(al.sym, &ignore_callees_regex)) {
> - /* Treat this symbol as the root,
> - forgetting its callees. */
> - *root_al = al;
> - callchain_cursor_reset(&callchain_cursor);
> + for (j = 0; j < mix_chain_nr; j++) {
> + struct addr_location al;
> +
> + if (callchain_param.order == ORDER_CALLEE) {
> + if (j < i + 2)
> + ip = chain->ips[j];
> + else
> + ip = lbr_stack->entries[j - i - 2].from;
> + } else {
> + if (j < lbr_nr)
> + ip = lbr_stack->entries[lbr_nr - j - 1].from;
> + else
> + ip = chain->ips[i + 1 - (j - lbr_nr)];
> }
> + err = __machine__resolve_callchain_sample(machine,
> + thread, ip, &cpumode, parent, root_al, &al);
> + /* Discard all when the callchain is corrupted */
> + if (err > 0)
> + return 0;
> + else if (err)
> + return err;
so you print FP callchains followed by LBR stack data, right?
but AFAICS from kernel changes the FP callchains and LBR callchains
data are unrelated.. 2 datasources of the same information
do we rather want to print them separately? or using an option
as Andi did in his lbr-as-callgraph patchset:
http://marc.info/?l=linux-kernel&m=141177467802602&w=2
thanks,
jirka
next prev parent reply other threads:[~2014-10-24 13:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 21:54 [PATCH V6 00/17] perf, x86: Haswell LBR call stack support Kan Liang
2014-10-19 21:54 ` [PATCH V6 01/17] perf, x86: Reduce lbr_sel_map size Kan Liang
2014-10-24 9:39 ` Peter Zijlstra
2014-11-04 1:07 ` Liang, Kan
2014-11-04 7:14 ` Peter Zijlstra
2014-11-04 7:16 ` Peter Zijlstra
2014-10-19 21:54 ` [PATCH V6 02/17] perf, core: introduce pmu context switch callback Kan Liang
2014-10-19 21:54 ` [PATCH V6 03/17] perf, x86: use context switch callback to flush LBR stack Kan Liang
2014-10-19 21:54 ` [PATCH V6 04/17] perf, x86: Basic Haswell LBR call stack support Kan Liang
2014-10-19 21:55 ` [PATCH V6 05/17] perf, core: pmu specific data for perf task context Kan Liang
2014-10-19 21:55 ` [PATCH V6 06/17] perf, core: always switch pmu specific data during context switch Kan Liang
2014-10-19 21:55 ` [PATCH V6 07/17] perf, x86: allocate space for storing LBR stack Kan Liang
2014-10-19 21:55 ` [PATCH V6 08/17] perf, x86: track number of events that use LBR callstack Kan Liang
2014-10-19 21:55 ` [PATCH V6 09/17] perf, x86: Save/resotre LBR stack during context switch Kan Liang
2014-10-19 21:55 ` [PATCH V6 10/17] perf, core: simplify need branch stack check Kan Liang
2014-10-19 21:55 ` [PATCH V6 11/17] perf, core: expose LBR call stack to user perf tool Kan Liang
2014-10-19 21:55 ` [PATCH V6 12/17] perf, x86: re-organize code that implicitly enables LBR/PEBS Kan Liang
2014-10-19 21:55 ` [PATCH V6 13/17] perf, x86: enable LBR callstack when recording callchain Kan Liang
2014-10-24 13:39 ` Jiri Olsa
2014-10-24 14:49 ` Liang, Kan
2014-10-19 21:55 ` [PATCH V6 14/17] perf, x86: disable FREEZE_LBRS_ON_PMI when LBR operates in callstack mode Kan Liang
2014-10-19 21:55 ` [PATCH V6 15/17] perf, x86: Discard zero length call entries in LBR call stack Kan Liang
2014-10-19 21:55 ` [PATCH V6 16/17] perf tools: handle LBR call stack data Kan Liang
2014-10-19 21:55 ` [PATCH V6 17/17] perf tools: choose to dump callchain from LBR and FP Kan Liang
2014-10-24 13:36 ` Jiri Olsa [this message]
2014-10-24 13:55 ` Jiri Olsa
2014-10-24 15:20 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024133600.GC1036@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).