From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Oded Gabbay <oded.gabbay@amd.com>
Cc: Joerg Roedel <jroedel@suse.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mm: export find_extend_vma and handle_mm_fault for driver use
Date: Wed, 29 Oct 2014 07:37:52 -0700 [thread overview]
Message-ID: <20141029073752.72e5f1c1@jbarnes-hsw> (raw)
In-Reply-To: <5450B472.1020301@amd.com>
Cool, thanks a lot, Oded. I guess my compiler did a good job making
sure there were no bugs. :)
Jesse
On Wed, 29 Oct 2014 11:33:38 +0200
Oded Gabbay <oded.gabbay@amd.com> wrote:
> Hi Joerg and Jesse,
>
> I tested our amdkfd driver with your patches applied (kernel 3.17.1).
> I run OpenCL tests, Aparapi/Sumatra (Java) and OpenMP
>
> All tests passed and I didn't see any kernel error messages.
>
> So:
>
> Tested-by: Oded Gabbay <oded.gabbay@amd.com>
>
> Oded
>
> On 10/27/2014 05:35 PM, Jesse Barnes wrote:
>
> Thanks, I have no way of testing this, but I'm hopeful. :)
>
> Jesse
>
> On Mon, 27 Oct 2014 17:15:45 +0200
> Oded Gabbay <oded.gabbay@amd.com> wrote:
>
> > Sure, no problem
> >
> > Oded
> >
> > On 10/27/2014 05:13 PM, Joerg Roedel wrote:
> >
> > Hi Oded,
> >
> > can you please test these patches with the KFD driver and make sure
> > nothing breaks for you? I really like this improvement and it would be
> > great to send it upstream for v3.19.
> >
> > Thanks,
> >
> > Joerg
> >
> > On Fri, Oct 24, 2014 at 12:34:30PM -0700, Jesse Barnes wrote:
> >
> >> This lets drivers like the AMD IOMMUv2 driver handle faults a bit more
> >> simply, rather than doing tricks with page refs and get_user_pages().
> >>
> >> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >> ---
> >> mm/memory.c | 1 +
> >> mm/mmap.c | 2 ++
> >> 2 files changed, 3 insertions(+)
> >>
> >> diff --git a/mm/memory.c b/mm/memory.c
> >> index 1cc6bfb..969ff0c 100644
> >> --- a/mm/memory.c
> >> +++ b/mm/memory.c
> >> @@ -3378,6 +3378,7 @@ int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct *vma,
> >>
> >> return ret;
> >> }
> >> +EXPORT_SYMBOL_GPL(handle_mm_fault);
> >>
> >> #ifndef __PAGETABLE_PUD_FOLDED
> >> /*
> >> diff --git a/mm/mmap.c b/mm/mmap.c
> >> index 7f85520..2ee7971 100644
> >> --- a/mm/mmap.c
> >> +++ b/mm/mmap.c
> >> @@ -2359,6 +2359,8 @@ find_extend_vma(struct mm_struct *mm, unsigned long addr)
> >> }
> >> #endif
> >>
> >> +EXPORT_SYMBOL_GPL(find_extend_vma);
> >> +
> >> /*
> >> * Ok - we have the memory areas we should free on the vma list,
> >> * so release them, and do the vma updates.
> >> --
> >> 1.9.1
>
>
>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-10-29 14:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 19:34 [PATCH 1/2] mm: export find_extend_vma and handle_mm_fault for driver use Jesse Barnes
2014-10-24 19:34 ` [PATCH 2/2] iommu/amd: use handle_mm_fault directly Jesse Barnes
2014-10-27 15:13 ` [PATCH 1/2] mm: export find_extend_vma and handle_mm_fault for driver use Joerg Roedel
2014-10-27 15:15 ` Oded Gabbay
2014-10-27 15:35 ` Jesse Barnes
2014-10-27 15:37 ` Oded Gabbay
2014-10-29 9:33 ` Oded Gabbay
2014-10-29 14:37 ` Jesse Barnes [this message]
2014-11-05 12:03 ` Joerg Roedel
2014-11-05 21:51 ` Jesse Barnes
2014-11-06 8:51 ` Oded Gabbay
2014-11-06 13:03 ` Joerg Roedel
2014-11-06 13:01 ` Joerg Roedel
2014-11-12 22:07 ` Jesse Barnes
2014-11-17 16:53 ` Joerg Roedel
2014-11-12 22:10 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029073752.72e5f1c1@jbarnes-hsw \
--to=jbarnes@virtuousgeek.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).