From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rabin Vincent <rabin@rab.in>,
linux-arm-kernel@lists.infradead.org,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range
Date: Thu, 30 Oct 2014 10:18:08 +0000 [thread overview]
Message-ID: <20141030101808.GO27405@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20141030082606.GA7945@infradead.org>
On Thu, Oct 30, 2014 at 01:26:06AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 29, 2014 at 11:06:58PM +0100, Rabin Vincent wrote:
> > ARM has some private syscalls (for example, set_tls(2)) which lie
> > outside the range of NR_syscalls. If any of these are called while
> > syscall tracing is being performed, out-of-bounds array access will
> > occur in the ftrace and perf sys_{enter,exit} handlers.
>
> While this patch looks like good caution, having syscalls outside of
> NR_syscalls seems like a receipe for a disaster. Can you try to fix
> that issue as ell, please?
No. We've had them since the inception of Linux on ARM. They predate
this tracing crap by more than a decade. We're not changing them
because that would be a massive user API breakage.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-10-30 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 22:06 [PATCH] tracing/syscalls: ignore numbers outside NR_syscalls' range Rabin Vincent
2014-10-30 8:26 ` Christoph Hellwig
2014-10-30 10:18 ` Russell King - ARM Linux [this message]
2014-10-30 11:10 ` Steven Rostedt
2014-10-30 11:14 ` Russell King - ARM Linux
2014-10-30 11:30 ` Steven Rostedt
2014-10-30 11:35 ` Russell King - ARM Linux
2014-11-03 17:08 ` Nathan Lynch
2014-11-03 17:58 ` Steven Rostedt
2014-10-30 11:52 ` Steven Rostedt
2014-10-30 11:55 ` Steven Rostedt
2014-10-31 10:01 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030101808.GO27405@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rabin@rab.in \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).