From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Raymond Tan <raymond.tan@intel.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, Alvin Chen <alvin.chen@intel.com>
Subject: Re: [PATCH 1/1] mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver
Date: Mon, 3 Nov 2014 13:09:49 +0000 [thread overview]
Message-ID: <20141103130949.GG4538@x1> (raw)
In-Reply-To: <1415005892.2396.82.camel@linux.intel.com>
On Mon, 03 Nov 2014, Andy Shevchenko wrote:
> On Mon, 2014-11-03 at 15:39 +0800, Raymond Tan wrote:
> > In Quark X1000, there's a single PCI device that provides both
> > an I2C controller and a GPIO controller. This MFD driver will
> > split the 2 devices for their respective drivers.
> >
> > This patch is based on Josef Ahmad's initial work for Quark enabling.
>
> Few comments below.
>
> After addressing take my
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[...]
> > +static const struct i2c_mode_info platform_i2c_mode_info[] = {
> > + {
> > + .name = "Galileo",
> > + .i2c_scl_freq = 100000,
> > + },
> > + {
> > + .name = "GalileoGen2",
> > + .i2c_scl_freq = 400000,
> > + },
>
> You can decrease indentation level if you want to by using
>
> = {{
> }, {
> }};
>
> Though I don't know if Lee likes it :-)
No, please don't do that.
[...]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-11-03 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 7:39 [PATCH 0/1] mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver Raymond Tan
2014-11-03 7:39 ` [PATCH 1/1] " Raymond Tan
2014-11-03 9:11 ` Andy Shevchenko
2014-11-03 13:09 ` Lee Jones [this message]
2014-11-11 12:57 ` Tan, Raymond
2014-11-03 9:43 ` Bryan O'Donoghue
2014-11-04 9:10 ` Shevchenko, Andriy
2014-11-04 9:22 ` Lee Jones
2014-11-03 10:35 ` Bryan O'Donoghue
2014-11-04 0:46 ` Chen, Alvin
2014-11-04 0:51 ` Chen, Alvin
2014-11-04 10:54 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103130949.GG4538@x1 \
--to=lee.jones@linaro.org \
--cc=alvin.chen@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raymond.tan@intel.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).