From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753652AbaKCV6m (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Nov 2014 16:58:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42171 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752954AbaKCV6i (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Nov 2014 16:58:38 -0500
Date: Mon, 3 Nov 2014 22:58:37 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jan Beulich <jbeulich@suse.com>, Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Sebastian Lackner <sebastian@fds-team.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chuck Ebbert <cebbert.lkml@gmail.com>, Anish Bhatt <anish@chelsio.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/asm] sched/x86_64: Don't save flags on context switch
Message-ID: <20141103215837.GB8711@redhat.com>
References: <bf6fb790787eb95b922157838f52712c25dda157.1412187233.git.luto@amacapital.net> <tip-2c7577a7583747c9b71f26dced7f696b739da745@git.kernel.org> <CALCETrWM2wVynp1rrip9AWtNYDzjC4M8JqKR82ew5dpyrTWMgA@mail.gmail.com> <20141103214712.GA8711@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141103214712.GA8711@redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/03, Oleg Nesterov wrote:
>
> On 11/03, Andy Lutomirski wrote:
> >
> > And do we ever have TF set during a context switch?  I hope not.
>
> I too hope.
>
> > Also, what's with 'jmp exit_intr' at the end of retint_kernel?  Why
> > isn't that 'jmp retint_kernel'?
>
> Even better, why not "jmp retint_restore_args" ?
>
> preempt_schedule_irq() checks need_resched() and returns with irqs
> disabled, not need to to recheck test_preempt_need_resched() ?

Btw, why retint_kernel() checks "interrupts on" ? It seems to me that
that "interrupts off" is not possible, no? And this will be more clear
when we remove the "exit_intr" label.

Oleg.