From: Jan Kara <jack@suse.cz>
To: Jan Beulich <JBeulich@suse.com>
Cc: Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: your patch "mm: Remove false WARN_ON from pagecache_isize_extended()"
Date: Tue, 4 Nov 2014 10:08:14 +0100 [thread overview]
Message-ID: <20141104090814.GA2953@quack.suse.cz> (raw)
In-Reply-To: <545890F40200007800044A31@mail.emea.novell.com>
On Tue 04-11-14 07:40:20, Jan Beulich wrote:
> >>> On 03.11.14 at 23:18, <david@fromorbit.com> wrote:
> > On Mon, Nov 03, 2014 at 04:41:13PM +0000, Jan Beulich wrote:
> >> having run into that warning too, I looked into it a little, and now
> >> having found that patch am pretty uncertain: Both truncate_setsize()
> >> and pagecache_isize_extended() document that they want to be
> >> called with i_mutex held, so removing the WARN_ON() alone seems
> >> either incomplete or wrong. What I found to work without violating
> >> this documented requirement is the patch below.
> >
> > Or, just perhaps, the comments are wrong....
>
> Right - that's what I was suggesting with the option of the patch
> being incomplete (rather than just removing the WARN_ON() it
> should also remove the respective comments then).
Yeah, I'll update the comments to mention there are filesystem which use
serialization different from i_mutex. Thanks for catching this.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2014-11-04 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 16:41 your patch "mm: Remove false WARN_ON from pagecache_isize_extended()" Jan Beulich
2014-11-03 22:18 ` Dave Chinner
2014-11-04 7:40 ` Jan Beulich
2014-11-04 9:08 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104090814.GA2953@quack.suse.cz \
--to=jack@suse.cz \
--cc=JBeulich@suse.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).