From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754341AbaKDOo1 (ORCPT ); Tue, 4 Nov 2014 09:44:27 -0500 Received: from helcar.apana.org.au ([209.40.204.226]:39726 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbaKDOoX (ORCPT ); Tue, 4 Nov 2014 09:44:23 -0500 Date: Tue, 4 Nov 2014 22:44:16 +0800 From: Herbert Xu To: Al Viro Cc: "David S. Miller" , netdev@vger.kernel.org, Linux Kernel Mailing List , Benjamin LaHaise Subject: Re: [PATCH 1/4] inet: Add skb_copy_datagram_iter Message-ID: <20141104144416.GB14743@gondor.apana.org.au> References: <20141104033818.GA11149@gondor.apana.org.au> <20141104143200.GC7996@ZenIV.linux.org.uk> <20141104143536.GD7996@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141104143536.GD7996@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 04, 2014 at 02:35:36PM +0000, Al Viro wrote: > On Tue, Nov 04, 2014 at 02:32:00PM +0000, Al Viro wrote: > > > Too noisy, IMO. How about skb_copy_datagram_msg() first? The fewer > > places have to even think of iovec or iov_iter, the better... > > PS: "too noisy" is about turning every callsite of skb_copy_datagram_iovec > into that of skb_copy_datagram_iter; the helper itself is just fine. Hmm if that is your concern then I don't see how skb_copy_datagram_msg changes things as you'd still have to convert every existing caller of skb_copy_datagram_iovec. Colour me confused. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt