From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: hch@lst.de, linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it
Date: Tue, 4 Nov 2014 16:03:03 +0000 [thread overview]
Message-ID: <20141104160301.GJ7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20141104155543.GD21902@quack.suse.cz>
On Tue, Nov 04, 2014 at 04:55:43PM +0100, Jan Kara wrote:
> > That consequence looks broken, IMO.
> Hum, it already behaves for block devices that way (and noone complained
> - but admittedly block devices tied to strange modules are less common than
> character devices). Also rmmod isn't that common IMO, but I see your point
> that it's unintuitive behavior.
Umm... Since when? The last time I looked, bdev module refcounts were
tied to struct gendisk, not to struct block_device.
next prev parent reply other threads:[~2014-11-04 16:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 20:14 [PATCH 0/4 v2] fs: Remove i_devices from struct inode Jan Kara
2014-10-22 20:14 ` [PATCH 1/4] blockdev: Don't use i_devices inode field Jan Kara
2014-11-04 9:42 ` Christoph Hellwig
2014-10-22 20:14 ` [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it Jan Kara
2014-11-04 9:52 ` Christoph Hellwig
2014-11-04 10:01 ` Jan Kara
2014-11-04 14:46 ` Al Viro
2014-11-04 15:37 ` Jan Kara
2014-11-04 15:40 ` Al Viro
2014-11-04 15:55 ` Jan Kara
2014-11-04 16:03 ` Al Viro [this message]
2014-11-05 16:54 ` Jan Kara
2014-10-22 20:14 ` [PATCH 3/4] chardev: Don't use i_devices inode field Jan Kara
2014-11-04 9:54 ` Christoph Hellwig
2014-10-22 20:14 ` [PATCH 4/4] fs: Remove i_devices list head Jan Kara
2014-11-04 9:55 ` Christoph Hellwig
2014-10-31 9:48 ` [PATCH 0/4 v2] fs: Remove i_devices from struct inode Jan Kara
2014-11-04 10:27 [PATCH 0/4 v3] " Jan Kara
2014-11-04 10:27 ` [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104160301.GJ7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).