From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Cc: Jarod Wilson <jarod@wilsonet.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Gulsah Kose <gulsah.1004@gmail.com>,
Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>,
Matina Maria Trompouki <mtrompou@gmail.com>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: lirc: replace dev_err by pr_err
Date: Wed, 5 Nov 2014 12:57:38 +0530 [thread overview]
Message-ID: <20141105072738.GB4881@sudip-PC> (raw)
In-Reply-To: <20141104214826.GA6793@localhost.localdomain>
On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote:
> On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote:
> > On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
> > > This patch replaces dev_err by pr_err since the value
> > > of ir is NULL when the message is displayed.
> > >
> > > Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > > ---
> > > drivers/staging/media/lirc/lirc_zilog.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> > > index 11a7cb1..ecdd71e 100644
> > > --- a/drivers/staging/media/lirc/lirc_zilog.c
> > > +++ b/drivers/staging/media/lirc/lirc_zilog.c
> > > @@ -1633,7 +1633,7 @@ out_put_xx:
> > > out_put_ir:
> > > put_ir_device(ir, true);
> > > out_no_ir:
> > > - dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> > > + pr_err("%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> > hi,
> > instead of ir->l.dev , can you please try dev_err like this :
> >
> > dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n",
> > __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
> > ret);
> >
>
> Thanks Sudip. It works. Please add the Reviewed-by tag to the newer
> patch.
>
i think you forgot to add cc to the list and Greg K-H in your reply.
Greg should know that this patch is now not required, otherwise he might apply it to his tree.
so just replying to your mail while adding everyone else in the cc.
thanks
sudip
> > thanks
> > sudip
> >
>
> Kind Regards,
> Aya Saif El-yazal Mahfouz
> >
> > > __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr,
> > > ret);
> > > mutex_unlock(&ir_devices_lock);
> > > --
> > > 1.9.3
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-11-05 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 0:13 [PATCH] staging: media: lirc: replace dev_err by pr_err Aya Mahfouz
2014-11-04 9:36 ` Sudip Mukherjee
[not found] ` <20141104214826.GA6793@localhost.localdomain>
2014-11-05 7:27 ` Sudip Mukherjee [this message]
2014-11-05 8:45 ` Aya Mahfouz
2014-11-05 10:14 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105072738.GB4881@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gulsah.1004@gmail.com \
--cc=jarod@wilsonet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=mtrompou@gmail.com \
--cc=tuomas.tynkkynen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).