linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: Cristian Stoica <cristian.stoica@freescale.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<horia.geanta@freescale.com>, <marex@denx.de>
Subject: Re: [PATCH v2] crypto: caam: fix error reporting
Date: Wed, 5 Nov 2014 10:43:32 -0600	[thread overview]
Message-ID: <20141105104332.bdc904792193d714bd9d4951@freescale.com> (raw)
In-Reply-To: <1415179284-19791-1-git-send-email-cristian.stoica@freescale.com>

On Wed, 5 Nov 2014 11:21:24 +0200
Cristian Stoica <cristian.stoica@freescale.com> wrote:

> The error code returned by hardware is four bits wide with an expected
> zero MSB. A hardware error condition where the error code can get between
> 0x8 and 0xf will trigger an out of bound array access on the error
> message table.
> This patch fixes the invalid array access following such an error and
> reports the condition.
> 
> Signed-off-by: Cristian Stoica <cristian.stoica@freescale.com>
> ---

no v2 change info?  All I noticed is the additional string for
"queue manager interface", which, without its implementation fn,
intoduces an inconsistency wrt NULL checking, so this comment:

http://www.mail-archive.com/linux-crypto@vger.kernel.org/msg12105.html

still applies.

Thanks,

Kim

  reply	other threads:[~2014-11-05 16:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31 16:57 [PATCH] crypto: caam: fix error reporting Cristian Stoica
2014-10-31 18:22 ` Kim Phillips
2014-11-01 11:43   ` Marek Vasut
2014-11-03  9:18   ` Cristian Stoica
2014-11-03 19:47     ` Kim Phillips
2014-11-04  8:57       ` Cristian Stoica
2014-11-04 16:57         ` Kim Phillips
2014-11-05  9:21           ` [PATCH v2] " Cristian Stoica
2014-11-05 16:43             ` Kim Phillips [this message]
2014-11-06  8:01               ` Cristian Stoica
2014-11-06 15:17             ` Herbert Xu
2014-11-05  9:27           ` [PATCH] " Cristian Stoica

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105104332.bdc904792193d714bd9d4951@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=cristian.stoica@freescale.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).