From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932480AbaKERGV (ORCPT ); Wed, 5 Nov 2014 12:06:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57678 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932194AbaKERGT (ORCPT ); Wed, 5 Nov 2014 12:06:19 -0500 Date: Wed, 5 Nov 2014 18:06:05 +0100 From: Petr Mladek To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Jiri Kosina , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [RFC][PATCH 10/12 v3] seq-buf: Make seq_buf_bprintf() conditional on CONFIG_BINARY_PRINTF Message-ID: <20141105170605.GL4570@pathway.suse.cz> References: <20141104155237.228431433@goodmis.org> <20141104160222.969013383@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141104160222.969013383@goodmis.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2014-11-04 10:52:47, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > The function bstr_printf() from lib/vsprnintf.c is only available if > CONFIG_BINARY_PRINTF is defined. This is due to the only user currently > being the tracing infrastructure, which needs to select this config > when tracing is configured. Until there is another user of the binary > printf formats, this will continue to be the case. > > Since seq_buf.c is now lives in lib/ and is compiled even without > tracing, it must encompass its use of bstr_printf() which is used > by seq_buf_printf(). This too is only used by the tracing infrastructure > and is still encapsulated by the CONFIG_BINARY_PRINTF. > > Signed-off-by: Steven Rostedt Please switch the order and do this change before moving to lib/. IMHO, the current order would break bisecting when tracing is disabled. Otherwise, the change looks good in itself, so: Reviewed-by: Petr Mladek Best Regards, Petr