From: Greg KH <gregkh@linuxfoundation.org>
To: sostalle <sean.stalley@intel.com>
Cc: steph <stephanie.s.wallick@intel.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver
Date: Wed, 5 Nov 2014 14:08:06 -0800 [thread overview]
Message-ID: <20141105220806.GB15806@kroah.com> (raw)
In-Reply-To: <20141105201433.GA4354@sean.stalley.intel.com>
On Wed, Nov 05, 2014 at 12:14:33PM -0800, sostalle wrote:
> On Mon, Nov 03, 2014 at 04:13:55PM -0800, Greg KH wrote:
> > On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote:
> > > On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote:
> > > > On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
> [snip]
> > > > > +static int mausb_hcd_init(void)
> > > > > +{
> > > > > + int ret;
> > > > > +
> > > > > + /* register HCD driver */
> > > > > + ret = platform_driver_register(&mausb_driver);
> > > >
> > > > Why is this a platform driver? How does this relate to platform
> > > > hardware?
> > > >
> > > The driver doesn't require platform resources. It looks like a host
> > > controller driver but communicates over the network instead of to
> > > a physical host controller. There is no MA USB-specific hardware.
> > >
> > > Should we use a struct device instead of a struct platform_device?
> >
> > Yes, please make it a "virtual" device.
> >
>
> Is it OK for our virtual host controller to use struct platform_device?
>
> The other virtual host controllers (usbip/vhci_hcd.c & gadget/udc/dummy_hcd.c)
> use the platform_device struct. Unless I am missing something, it doesn't look
> like the other virtual host controllers use platform resources.
>
> If it is not ok, is there a good example somewhere of a virtual non-platform
> device?
If your device is not really a platform device (i.e. no platform
resources), then just create a virtual device with a call to
device_create() and don't pass in a parent pointer. But you need to
create a class for it, which is a pain, but shouldn't be that hard.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2014-11-05 22:08 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <MA USB drivers>
2014-11-03 20:42 ` [PATCH 00/10] MA USB drivers cover letter Stephanie Wallick
2014-11-03 20:42 ` [PATCH 01/10] added media agnostic (MA) USB HCD driver Stephanie Wallick
2014-11-03 21:18 ` Greg KH
2014-11-03 23:47 ` steph
2014-11-03 21:21 ` Greg KH
2014-11-04 0:04 ` steph
2014-11-04 0:13 ` Greg KH
2014-11-04 0:59 ` steph
2014-11-05 20:14 ` sostalle
2014-11-05 22:08 ` Greg KH [this message]
2014-11-03 20:42 ` [PATCH 02/10] added media agnostic (MA) USB HCD roothubs Stephanie Wallick
2014-11-03 20:42 ` [PATCH 03/10] added media agnostic (MA) data structures and handling Stephanie Wallick
2014-11-03 20:42 ` [PATCH 04/10] added media agnostic (MA) USB packet handling Stephanie Wallick
2014-11-03 20:42 ` [PATCH 05/10] added media specific (MS) TCP drivers Stephanie Wallick
2014-11-04 8:48 ` Tobias Klauser
2014-11-04 18:02 ` Greg KH
2014-11-12 19:36 ` Sean O. Stalley
2014-11-03 20:42 ` [PATCH 06/10] added media agnostic (MA) UDC Stephanie Wallick
2014-11-03 20:42 ` [PATCH 07/10] added media agnostic (MA) USB management packet handling Stephanie Wallick
2014-11-03 20:42 ` [PATCH 08/10] added media agnostic (MA) USB data " Stephanie Wallick
2014-11-03 20:42 ` [PATCH 09/10] added tools for building/loading media agnostic (MA) USB drivers Stephanie Wallick
2014-11-03 20:42 ` [PATCH 10/10] added kernel build, configuration, and TODO files Stephanie Wallick
2014-11-03 21:22 ` Greg KH
2014-11-03 21:24 ` Greg KH
[not found] ` <54591319.c3b5440a.7374.5f85SMTPIN_ADDED_BROKEN@mx.google.com>
2014-11-04 18:02 ` Greg KH
2014-11-04 9:00 ` [PATCH 00/10] MA USB drivers cover letter Bjørn Mork
2014-11-05 1:31 ` sostalle
2014-11-11 2:09 ` [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver Stephanie Wallick
2014-11-11 2:09 ` [V2 PATCH 02/10] added media agnostic (MA) USB HCD roothubs Stephanie Wallick
2014-11-12 8:35 ` Oliver Neukum
2014-11-12 19:28 ` Sean O. Stalley
2014-11-12 19:52 ` Alan Stern
2014-11-11 2:09 ` [V2 PATCH 03/10] added media agnostic (MA) data structures and handling Stephanie Wallick
2014-11-11 4:38 ` Greg KH
2014-11-11 22:42 ` Sean O. Stalley
2014-11-12 1:14 ` Greg KH
2014-11-12 2:01 ` steph
2014-11-11 2:09 ` [V2 PATCH 04/10] added media agnostic (MA) USB packet handling Stephanie Wallick
2014-11-12 14:01 ` Oliver Neukum
2014-11-11 2:09 ` [V2 PATCH 05/10] added media specific (MS) TCP drivers Stephanie Wallick
2014-11-11 4:21 ` Greg KH
2014-11-11 2:09 ` [V2 PATCH 06/10] added media agnostic (MA) UDC Stephanie Wallick
2014-11-11 2:09 ` [V2 PATCH 07/10] added media agnostic (MA) USB management packet handling Stephanie Wallick
2014-11-11 2:09 ` [V2 PATCH 08/10] added media agnostic (MA) USB data " Stephanie Wallick
2014-11-11 2:09 ` [V2 PATCH 09/10] added tools for building/loading media agnostic (MA) USB drivers Stephanie Wallick
2014-11-11 2:09 ` [V2 PATCH 10/10] added kernel build, configuration, and TODO files Stephanie Wallick
2014-11-11 4:23 ` Greg KH
2014-11-11 4:08 ` [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver Greg KH
2014-11-11 15:54 ` Alan Stern
2014-11-12 21:40 ` Sean O. Stalley
2014-11-12 22:03 ` Alan Stern
2014-11-14 22:48 ` Sean O. Stalley
2014-11-15 21:29 ` Alan Stern
2014-11-12 22:58 ` Sean O. Stalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105220806.GB15806@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.stalley@intel.com \
--cc=stephanie.s.wallick@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).