linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Kanaka Juvva <kanaka.d.juvva@intel.com>,
	Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v3 10/11] perf/x86/intel: Perform rotation on Intel CQM RMIDs
Date: Fri, 7 Nov 2014 13:58:57 +0100	[thread overview]
Message-ID: <20141107125857.GF3337@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1415276602-10337-11-git-send-email-matt@console-pimps.org>

On Thu, Nov 06, 2014 at 12:23:21PM +0000, Matt Fleming wrote:
> +static unsigned int __rotation_period = 250; /* ms */

There's two things being conflated here I think, even though they're
related.

The one is how long we'll let RMIDs settle before trying to reuse them,
the second is how often we attempt the rotation. Clearly the rotation
time is limited by the settle time, but they need not be the same.

Also, we already have a per pmu rotation interval in
pmu::hrtimer_interval_ms, I suppose we should reuse that to be
consistent.

  parent reply	other threads:[~2014-11-07 12:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 12:23 [PATCH v3 00/11] perf: Intel Cache QoS Monitoring support Matt Fleming
2014-11-06 12:23 ` [PATCH 01/11] perf tools: Parse event per-package info files Matt Fleming
2014-11-06 12:23 ` [PATCH 02/11] perf tools: Implement snapshot event file logic Matt Fleming
2014-11-06 12:23 ` [PATCH 03/11] perf: Make perf_cgroup_from_task() global Matt Fleming
2014-11-06 12:23 ` [PATCH 04/11] perf: Add ->count() function to read per-package counters Matt Fleming
2014-11-06 12:23 ` [PATCH v3 05/11] perf: Move cgroup init before PMU ->event_init() Matt Fleming
2014-11-06 12:23 ` [PATCH 06/11] x86: Add support for Intel Cache QoS Monitoring (CQM) detection Matt Fleming
2014-11-06 12:23 ` [PATCH v3 07/11] perf/x86/intel: Add Intel Cache QoS Monitoring support Matt Fleming
2014-11-06 12:23 ` [PATCH 08/11] perf/x86/intel: Implement LRU monitoring ID allocation for CQM Matt Fleming
2014-11-06 12:23 ` [PATCH 09/11] perf/x86/intel: Support task events with Intel CQM Matt Fleming
2014-11-07  9:08   ` Peter Zijlstra
2014-11-07 10:09     ` Matt Fleming
2014-11-07 11:22       ` Peter Zijlstra
2014-11-06 12:23 ` [PATCH v3 10/11] perf/x86/intel: Perform rotation on Intel CQM RMIDs Matt Fleming
2014-11-07 12:06   ` Peter Zijlstra
2014-11-10 20:43     ` Matt Fleming
2014-11-10 20:58       ` Peter Zijlstra
2014-11-07 12:18   ` Peter Zijlstra
2014-11-10 20:50     ` Matt Fleming
2014-11-07 12:20   ` Peter Zijlstra
2014-11-10 20:56     ` Matt Fleming
2014-11-10 21:08       ` Peter Zijlstra
2014-11-07 12:34   ` Peter Zijlstra
2014-11-07 12:38     ` Peter Zijlstra
2014-11-14 12:35       ` Matt Fleming
2014-11-10 21:31     ` Matt Fleming
2014-11-11  9:37       ` Peter Zijlstra
2014-11-07 12:58   ` Peter Zijlstra [this message]
2014-11-06 12:23 ` [PATCH 11/11] perf/x86/intel: Enable conflicting event scheduling for CQM Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141107125857.GF3337@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=kanaka.d.juvva@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matt@console-pimps.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).