From: Greg KH <gregkh@linuxfoundation.org>
To: Seth Jennings <sjenning@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Kosina <jkosina@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
live-patching@vger.kernel.org, kpatch@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Kernel Live Patching
Date: Sun, 9 Nov 2014 12:16:41 -0800 [thread overview]
Message-ID: <20141109201641.GA21349@kroah.com> (raw)
In-Reply-To: <1415284748-14648-1-git-send-email-sjenning@redhat.com>
On Thu, Nov 06, 2014 at 08:39:06AM -0600, Seth Jennings wrote:
> This patchset implements an ftrace-based mechanism and kernel interface for
> doing live patching of kernel and kernel module functions. It represents the
> greatest common functionality set between kpatch [1] and kGraft [2] and can
> accept patches built using either method. This solution was discussed in the
> Live Patching Mini-conference at LPC 2014 [3].
>
> The model consists of a live patching "core" that provides an interface for
> other "patch" kernel modules to register patches with the core.
>
> Patch modules contain the new function code and create an lp_patch
> structure containing the required data about what functions to patch, where the
> new code for each patched function resides, and in which kernel object (vmlinux
> or module) the function to be patch resides. The patch module then invokes the
> lp_register_patch() function to register with the core module, then
> lp_enable_patch() to have to core module redirect the execution paths using
> ftrace.
>
> An example patch module can be found here:
> https://github.com/spartacus06/livepatch/blob/master/patch/patch.c
>
> The live patching core creates a sysfs hierarchy for user-level access to live
> patching information. The hierarchy is structured like this:
>
> /sys/kernel/livepatch
> /sys/kernel/livepatch/<patch>
> /sys/kernel/livepatch/<patch>/enabled
> /sys/kernel/livepatch/<patch>/<object>
> /sys/kernel/livepatch/<patch>/<object>/<func>
> /sys/kernel/livepatch/<patch>/<object>/<func>/new_addr
> /sys/kernel/livepatch/<patch>/<object>/<func>/old_addr
You are creating sysfs attributes with no Documentation/ABI/ entries,
please fix that in future patches.
thanks,
greg k-h
prev parent reply other threads:[~2014-11-09 20:18 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 14:39 [PATCH 0/2] Kernel Live Patching Seth Jennings
2014-11-06 14:39 ` [PATCH 1/2] kernel: add TAINT_LIVEPATCH Seth Jennings
2014-11-09 20:19 ` Greg KH
2014-11-11 14:54 ` Seth Jennings
2014-11-06 14:39 ` [PATCH 2/2] kernel: add support for live patching Seth Jennings
2014-11-06 15:11 ` Jiri Kosina
2014-11-06 16:20 ` Seth Jennings
2014-11-06 16:32 ` Josh Poimboeuf
2014-11-06 18:00 ` Vojtech Pavlik
2014-11-06 22:20 ` Jiri Kosina
2014-11-07 12:50 ` Josh Poimboeuf
2014-11-07 13:13 ` Jiri Kosina
2014-11-07 13:22 ` Josh Poimboeuf
2014-11-07 14:57 ` Seth Jennings
2014-11-06 15:51 ` Jiri Slaby
2014-11-06 16:57 ` Seth Jennings
2014-11-06 17:12 ` Josh Poimboeuf
2014-11-07 18:21 ` Petr Mladek
2014-11-07 20:31 ` Josh Poimboeuf
2014-11-30 12:23 ` Pavel Machek
2014-12-01 16:49 ` Seth Jennings
2014-11-06 20:02 ` Steven Rostedt
2014-11-06 20:19 ` Seth Jennings
2014-11-07 17:13 ` module notifier: was " Petr Mladek
2014-11-07 18:07 ` Seth Jennings
2014-11-07 18:40 ` Petr Mladek
2014-11-07 18:55 ` Seth Jennings
2014-11-11 19:40 ` Seth Jennings
2014-11-11 22:17 ` Jiri Kosina
2014-11-11 22:48 ` Seth Jennings
2014-11-07 17:39 ` more patches for the same func: " Petr Mladek
2014-11-07 21:54 ` Josh Poimboeuf
2014-11-07 19:40 ` Andy Lutomirski
2014-11-07 19:42 ` Seth Jennings
2014-11-07 19:52 ` Seth Jennings
2014-11-10 10:08 ` Jiri Kosina
2014-11-10 17:31 ` Josh Poimboeuf
2014-11-13 10:16 ` Miroslav Benes
2014-11-13 14:38 ` Josh Poimboeuf
2014-11-13 17:12 ` Seth Jennings
2014-11-14 13:30 ` Miroslav Benes
2014-11-14 14:52 ` Petr Mladek
2014-11-06 18:44 ` [PATCH 0/2] Kernel Live Patching Christoph Hellwig
2014-11-06 18:51 ` Vojtech Pavlik
2014-11-06 18:58 ` Christoph Hellwig
2014-11-06 19:34 ` Josh Poimboeuf
2014-11-06 19:49 ` Steven Rostedt
2014-11-06 20:02 ` Josh Poimboeuf
2014-11-07 7:46 ` Christoph Hellwig
2014-11-07 7:45 ` Christoph Hellwig
2014-11-06 20:24 ` Vojtech Pavlik
2014-11-07 7:47 ` Christoph Hellwig
2014-11-07 13:11 ` Josh Poimboeuf
2014-11-07 14:04 ` Vojtech Pavlik
2014-11-07 15:45 ` Josh Poimboeuf
2014-11-07 21:27 ` Vojtech Pavlik
2014-11-08 3:45 ` Josh Poimboeuf
2014-11-08 8:07 ` Vojtech Pavlik
2014-11-10 17:09 ` Josh Poimboeuf
2014-11-11 9:05 ` Vojtech Pavlik
2014-11-11 17:45 ` Josh Poimboeuf
2014-11-11 1:24 ` Masami Hiramatsu
2014-11-11 10:26 ` Vojtech Pavlik
2014-11-12 17:33 ` Masami Hiramatsu
2014-11-12 21:47 ` Vojtech Pavlik
2014-11-13 15:56 ` Masami Hiramatsu
2014-11-13 16:38 ` Vojtech Pavlik
2014-11-18 12:47 ` Petr Mladek
2014-11-18 18:58 ` Josh Poimboeuf
2014-11-07 12:31 ` Josh Poimboeuf
2014-11-07 12:48 ` Vojtech Pavlik
2014-11-07 13:06 ` Josh Poimboeuf
2014-11-09 20:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141109201641.GA21349@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=kpatch@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).