From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Chen Yucong <slaoub@gmail.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"aravind.gopalakrishnan@amd.com" <aravind.gopalakrishnan@amd.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] x86, mce: support memory error recovery for both UCNA and Deferred error in machine_check_poll
Date: Mon, 10 Nov 2014 22:47:39 +0100 [thread overview]
Message-ID: <20141110214739.GB4366@pd.tnic> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F329281E9@ORSMSX114.amr.corp.intel.com>
On Mon, Nov 10, 2014 at 09:44:26PM +0000, Luck, Tony wrote:
> > In fact, you could redo this patch in the meantime without the AMD vendor
> > check so that Tony can pick them up soon. I'll add the correct AMD bits
> > later.
>
> You just want this hunk deleted ...
>
> + if (c->x86_vendor == X86_VENDOR_AMD) {
> + /*
> + * AMD BKDGs - Machine Check Error Codes
> + *
> + * Bit 8 of ErrCode[15:0] of MCi_STATUS is used for indicating
> + * a memory-specific error. Note that this field encodes info-
> + * rmation about memory-hierarchy level involved in the error.
> + */
> + return (m->status & 0xff00) == BIT(8);
> + } else
>
> I can do that without a repost. Or I can leave a reminder ...
>
> + if (c->x86_vendor == X86_VENDOR_AMD) {
> + /*
> + * coming soon
> + */
> + return false;
> + } else
Ok, that's fine too. I'll try to have a fix for this very soon so that
we can be just in time ready to go for 3.19.
With that you can slap
Acked-by: Borislav Petkov <bp@suse.de>
to them.
Thanks Tony.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-11-10 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 1:40 [PATCH v3 0/2]RAS: add the support for handling UCNA/DEFERRED error Chen Yucong
2014-11-08 1:40 ` [PATCH v3 1/2] x86, mce, severity: extend the the mce_severity mechanism to handle " Chen Yucong
2014-11-10 22:06 ` Aravind Gopalakrishnan
2014-11-10 22:17 ` Borislav Petkov
2014-11-10 23:03 ` Aravind Gopalakrishnan
2014-11-10 23:32 ` Luck, Tony
2014-11-11 8:56 ` Borislav Petkov
2014-11-11 18:44 ` Luck, Tony
2014-11-12 1:03 ` Chen Yucong
2014-11-12 18:28 ` Luck, Tony
2014-11-08 1:40 ` [PATCH v3 2/2] x86, mce: support memory error recovery for both UCNA and Deferred error in machine_check_poll Chen Yucong
2014-11-10 19:06 ` Borislav Petkov
2014-11-10 21:37 ` Borislav Petkov
2014-11-10 21:44 ` Luck, Tony
2014-11-10 21:47 ` Borislav Petkov [this message]
2014-11-10 16:42 ` [PATCH v3 0/2]RAS: add the support for handling UCNA/DEFERRED error Borislav Petkov
2014-11-10 18:47 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110214739.GB4366@pd.tnic \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slaoub@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).