From: Stephen Boyd <sboyd@codeaurora.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Mike Turquette <mturquette@linaro.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 6/7] clk: Make clk API return per-user struct clk instances
Date: Thu, 13 Nov 2014 23:06:46 -0800 [thread overview]
Message-ID: <20141114070646.GA11808@codeaurora.org> (raw)
In-Reply-To: <1414666135-14313-7-git-send-email-tomeu.vizoso@collabora.com>
On 10/30, Tomeu Vizoso wrote:
> Moves clock state to struct clk_core, but takes care to change as little API as
> possible.
>
> struct clk_hw still has a pointer to a struct clk, which is the
> implementation's per-user clk instance, for backwards compatibility.
>
> The struct clk that clk_get_parent() returns isn't owned by the caller, but by
> the clock implementation, so the former shouldn't call clk_put() on it.
>
> Because some boards in mach-omap2 still register clocks statically, their clock
> registration had to be updated to take into account that the clock information
> is stored in struct clk_core now.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
It would be good to have Russell at least ack the clkdev bits.
There's still more work to do in the future here, but
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2014-11-14 7:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 10:48 [PATCH v5 0/7] Per-user clock constraints Tomeu Vizoso
2014-10-30 10:48 ` [PATCH v5 1/7] clk: Remove unused function __clk_get_prepare_count Tomeu Vizoso
2014-10-30 10:48 ` [PATCH v5 2/7] clk: Don't try to use a struct clk* after it could have been freed Tomeu Vizoso
2014-10-30 10:48 ` [PATCH v5 3/7] clk: Don't expose __clk_get_accuracy Tomeu Vizoso
2014-10-30 10:48 ` [PATCH v5 4/7] clk: change clk_debugfs_add_file to take a struct clk_hw Tomeu Vizoso
2014-10-30 10:48 ` [PATCH v5 5/7] clk: Change clk_ops->determine_rate to return a clk_hw as the best parent Tomeu Vizoso
2014-10-30 10:48 ` [PATCH v5 6/7] clk: Make clk API return per-user struct clk instances Tomeu Vizoso
2014-11-14 7:06 ` Stephen Boyd [this message]
2014-11-19 14:55 ` Tomeu Vizoso
2014-10-30 10:48 ` [PATCH v5 7/7] clk: Add floor and ceiling constraints to clock rates Tomeu Vizoso
2014-11-14 7:50 ` Stephen Boyd
2014-11-18 16:31 ` Tomeu Vizoso
2014-11-22 2:35 ` Stephen Boyd
2014-11-28 13:23 ` Tomeu Vizoso
2014-10-31 11:33 ` [PATCH v5 0/7] Per-user clock constraints Peter De Schrijver
2014-11-14 6:28 ` Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114070646.GA11808@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=paul@pwsan.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).