From: Petr Mladek <pmladek@suse.cz>
To: Tejun Heo <tj@kernel.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Jiri Kosina <jkosina@suse.cz>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] virtio_balloon: Convert "vballon" kthread into a workqueue
Date: Fri, 14 Nov 2014 18:42:52 +0100 [thread overview]
Message-ID: <20141114174252.GE7969@dhcp128.suse.cz> (raw)
In-Reply-To: <20141114131915.GD21209@htj.dyndns.org>
On Fri 2014-11-14 08:19:15, Tejun Heo wrote:
> Hello, Michael, Petr.
>
> On Wed, Nov 12, 2014 at 03:32:04PM +0200, Michael S. Tsirkin wrote:
> > > + /* The workqueue servicing the balloon. */
> > > + struct workqueue_struct *wq;
> > > + struct work_struct wq_work;
> >
> > We could use system_freezable_wq instead.
> > I do agree a dedicated wq is better since this can get blocked
> > for a long time while allocating memory.
> > However, please add a comment to this effect.
>
> system_freezable_wq should be fine. Workqueues by default have a
> pretty high maximum concurrency level (256). There's no reason to
> create separate workqueues solely for that purpose.
Great. If nobody complains until next week, I will send an updated
patch with the system workqueue and also with the fixed typos.
Thanks all reviewers for nice hints.
Best Regards,
Petr
next prev parent reply other threads:[~2014-11-14 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 13:02 [PATCH v2] virtio_balloon: Convert "vballon" kthread into a workqueue Petr Mladek
2014-11-12 13:32 ` Michael S. Tsirkin
2014-11-14 13:19 ` Tejun Heo
2014-11-14 17:42 ` Petr Mladek [this message]
2014-11-12 18:50 ` Jeff Epler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141114174252.GE7969@dhcp128.suse.cz \
--to=pmladek@suse.cz \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).