From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbaKQKFZ (ORCPT ); Mon, 17 Nov 2014 05:05:25 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:60115 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbaKQKFX (ORCPT ); Mon, 17 Nov 2014 05:05:23 -0500 Date: Mon, 17 Nov 2014 11:05:19 +0100 From: Pavel Machek To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, freemangordon@abv.bg, bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sakari.ailus@iki.fi, devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [RFC] adp1653: Add device tree bindings for LED controller Message-ID: <20141117100519.GA4353@amd> References: <20141116075928.GA9763@amd> <201411170943.20810@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201411170943.20810@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Mon 2014-11-17 09:43:19, Pali Rohár wrote: > On Sunday 16 November 2014 08:59:28 Pavel Machek wrote: > > For device tree people: Yes, I know I'll have to create file > > in documentation, but does the binding below look acceptable? > > > > I'll clean up driver code a bit more, remove the printks. > > Anything else obviously wrong? > I think that this patch is probably not good and specially not > for n900. adp1653 should be registered throw omap3 isp camera > subsystem which does not have DT support yet. Can you explain? adp1653 is independend device on i2c bus, and we have kernel driver for it (unlike rest of n900 camera system). Just now it is unusable due to lack of DT binding. It has two functions, LED light and a camera flash; yes, the second one should be integrated to the rest of camera system, but that is not yet merged. That should not prevent us from merging DT support for the flash, so that this part can be tested/maintained. > See n900 legacy board camera code in file board-rx51-camera.c. I have seen that. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html