From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753460AbaKRIFG (ORCPT ); Tue, 18 Nov 2014 03:05:06 -0500 Received: from mail-pd0-f179.google.com ([209.85.192.179]:47559 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbaKRIFE (ORCPT ); Tue, 18 Nov 2014 03:05:04 -0500 Date: Tue, 18 Nov 2014 17:04:51 +0900 From: Gyungoh Yoo To: Mark Brown Cc: sameo@linux.intel.com, lee.jones@linaro.org, jg1.han@samsung.com, cooloney@gmail.com, lgirdwood@gmail.com, jack.yoo@skyworksinc.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, grant.likely@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, pawel.moll@arm.com, heiko@sntech.de, jason@lakedaemon.net, shawn.guo@freescale.com, treding@nvidia.com, florian.vaussard@epfl.ch, trivial@kernel.org, linux@roeck-us.net, andrew@lunn.ch, jic23@kernel.org Subject: Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure Message-ID: <20141118080451.GA3319@jack-ThinkPad-T520> References: <1416213190-20935-1-git-send-email-jack.yoo@skyworksinc.com> <1416213190-20935-8-git-send-email-jack.yoo@skyworksinc.com> <20141117141836.GA2722@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20141117141836.GA2722@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 17, 2014 at 02:18:36PM +0000, Mark Brown wrote: > On Mon, Nov 17, 2014 at 05:33:08PM +0900, gyungoh@gmail.com wrote: > > > np = of_get_child_by_name(dev->parent->of_node, "regulator"); > > > + ret = of_regulator_match(dev, np, &sky81452_match, 1); > > Don't open code this, use regulators_node and of_match as previously > advised. I think I had a misunderstanding. But I have no idea about regulators_node and of_match. Could you let me know more about them? Thanks.