From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: Daniel Borkmann <dborkman@redhat.com>,
quentin.gouchet@gmail.com, LKML <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, ABI/API <linux-api@vger.kernel.org>
Subject: Re: [PATCH v2 06/10] crypto: AF_ALG: make setkey optional
Date: Tue, 18 Nov 2014 22:10:13 +0800 [thread overview]
Message-ID: <20141118141013.GC12100@gondor.apana.org.au> (raw)
In-Reply-To: <2196615.OgfUNzPKdf@tachyon.chronox.de>
On Sun, Nov 16, 2014 at 03:26:58AM +0100, Stephan Mueller wrote:
> The current AF_ALG implementation requires that a userspace interface
> implementation must provide a callback for setkey. Such a call is not
> appliable to random number generators.
>
> To prepare AF_ALG for the addition of a random number generator user
> space interface, this function callback invocation is made optional.
>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>
Did you actually try this? AFAICS setkey is already optional.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2014-11-18 14:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 2:23 [PATCH v2 00/10] crypto: AF_ALG: add AEAD and RNG support Stephan Mueller
2014-11-16 2:23 ` [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD Stephan Mueller
2014-11-18 14:06 ` Herbert Xu
2014-11-19 0:34 ` Stephan Mueller
2014-11-19 4:20 ` Stephan Mueller
2014-11-19 4:27 ` Herbert Xu
2014-11-19 6:30 ` Stephan Mueller
2014-11-19 6:45 ` Herbert Xu
2014-11-16 2:24 ` [PATCH v2 02/10] crypto: AF_ALG: user space interface for cipher info Stephan Mueller
2014-11-18 14:08 ` Herbert Xu
2014-11-19 1:02 ` Stephan Mueller
2014-11-19 1:05 ` Herbert Xu
2014-11-20 4:03 ` Stephan Mueller
2014-11-20 4:07 ` Herbert Xu
2014-11-20 4:14 ` Stephan Mueller
2014-11-20 4:18 ` Herbert Xu
2014-11-20 4:23 ` Stephan Mueller
2014-11-20 4:46 ` crypto: user - Allow get request with empty driver name Herbert Xu
2014-11-20 7:11 ` Steffen Klassert
2014-11-20 7:45 ` Herbert Xu
2014-11-20 8:04 ` Steffen Klassert
2014-11-20 13:07 ` Stephan Mueller
2014-11-20 13:02 ` Stephan Mueller
2014-11-20 13:10 ` Stephan Mueller
2014-11-20 13:40 ` Herbert Xu
2014-11-20 16:08 ` Stephan Mueller
2014-11-21 2:31 ` Herbert Xu
2014-11-21 2:42 ` Stephan Mueller
2014-11-21 4:40 ` Stephan Mueller
2014-11-20 6:32 ` [PATCH v2 02/10] crypto: AF_ALG: user space interface for cipher info Steffen Klassert
2014-11-20 7:05 ` Steffen Klassert
2014-11-16 2:25 ` [PATCH v2 03/10] crypto: AF_ALG: extend data structuers for AEAD Stephan Mueller
2014-11-16 2:25 ` [PATCH v2 04/10] crypto: AF_ALG: crypto API calls to inline functions Stephan Mueller
2014-11-16 2:26 ` [PATCH v2 05/10] crypto: AF_ALG: add AEAD support Stephan Mueller
2014-11-16 2:26 ` [PATCH v2 06/10] crypto: AF_ALG: make setkey optional Stephan Mueller
2014-11-18 14:10 ` Herbert Xu [this message]
2014-11-19 2:36 ` Stephan Mueller
2014-11-16 2:27 ` [PATCH v2 07/10] crypto: AF_ALG: add random number generator support Stephan Mueller
2014-11-16 2:28 ` [PATCH v2 08/10] crypto: AF_ALG: enable RNG interface compilation Stephan Mueller
2014-11-16 2:28 ` [PATCH v2 09/10] crypto: AF_ALG: user space interface for hash info Stephan Mueller
2014-11-16 2:29 ` [PATCH v2 10/10] crypto: AF_ALG: document the user space interface Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118141013.GC12100@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dborkman@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin.gouchet@gmail.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).