From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754698AbaKROYS (ORCPT ); Tue, 18 Nov 2014 09:24:18 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57768 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754556AbaKROYO (ORCPT ); Tue, 18 Nov 2014 09:24:14 -0500 Date: Tue, 18 Nov 2014 15:24:21 +0100 From: Petr Mladek To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Jiri Kosina Subject: Re: [PATCH 13/26 v5] tracing: Fix return value of ftrace_raw_output_prep() Message-ID: <20141118142421.GH23958@pathway.suse.cz> References: <20141115045847.712848224@goodmis.org> <20141115050602.820661984@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141115050602.820661984@goodmis.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2014-11-14 23:59:00, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > If the trace_seq of ftrace_raw_output_prep() is full this function > returns TRACE_TYPE_PARTIAL_LINE, otherwise it returns zero. > > The problem is that TRACE_TYPE_PARTIAL_LINE happens to be zero! > > The thing is, the caller of ftrace_raw_output_prep() expects a > success to be zero. Change that to expect it to be > TRACE_TYPE_HANDLED. > > Link: http://lkml.kernel.org/r/20141114112522.GA2988@dhcp128.suse.cz > > Reminded-by: Petr Mladek > Signed-off-by: Steven Rostedt Reviewed-by: Petr Mladek Best Regards, Petr