From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932835AbaKRW7p (ORCPT ); Tue, 18 Nov 2014 17:59:45 -0500 Received: from 1wt.eu ([62.212.114.60]:53557 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932149AbaKRW7o (ORCPT ); Tue, 18 Nov 2014 17:59:44 -0500 Date: Tue, 18 Nov 2014 23:59:38 +0100 From: Willy Tarreau To: Mariusz Gorski Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/9] staging: panel: Refactor LCD init code Message-ID: <20141118225938.GP26514@1wt.eu> References: <1416344174-9155-1-git-send-email-marius.gorski@gmail.com> <1416344174-9155-8-git-send-email-marius.gorski@gmail.com> <20141118212326.GJ26514@1wt.eu> <20141118215108.GD10306@firebird> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141118215108.GD10306@firebird> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 18, 2014 at 10:51:08PM +0100, Mariusz Gorski wrote: > On Tue, Nov 18, 2014 at 10:23:26PM +0100, Willy Tarreau wrote: > > On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote: > > > Rework lcd_init method to make it a little bit more clear about > > > the precedence of the params, move LCD geometry and pins layout > > > to the LCD struct and thus make the LCD-related module params > > > effectively read-only. > > > > > > Signed-off-by: Mariusz Gorski > > > > Acked-by: Willy Tarreau > > > > I like this refactoring. However I don't know if you got your LCD module > > to work or not, but for such important changes you should definitely test > > the code, since it's very easy to introduce minor bugs or even to fix a > > bug that used to make the whole driver work... > > > > Willy > > > Yes, I have tested this code with my LCD module and it works > as before. great! > This is what I've emphasized in the cover letter - > - I made sure (and tested), that all lcd and keypad params are > set to the same state as before this patch series, and that > the current behaviour of the module doesn't change. I've tested > all profile/lcd_type combinations in an automated way to catch > any edge cases :) "tested" was not mentionned in the cover letter, hence my asking :-) Willy