From: Grant Likely <grant.likely@linaro.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rob Herring <robherring2@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of/address: Don't throw errors on absent ranges\r properties
Date: Wed, 19 Nov 2014 10:31:40 +0000 [thread overview]
Message-ID: <20141119103140.2B9F4C40551@trevor.secretlab.ca> (raw)
In-Reply-To: <1416364351.5704.22.camel@kernel.crashing.org>
On Wed, 19 Nov 2014 13:32:31 +1100
, Benjamin Herrenschmidt <benh@kernel.crashing.org>
wrote:
> On Tue, 2014-11-18 at 16:57 +0000, Grant Likely wrote:
> > On Fri, 14 Nov 2014 17:58:23 +1100
> > , Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > wrote:
> > > The core always tries to translate any "reg" property to construct the platform
> > > device names. This results in a pile of "OF: no ranges; cannot translate" errors
> > > in dmesg whenever we expose things like i2c devices that cannot directly translate
> > > to the MMIO space.
> >
> > I don't have a problem with the change, but it seems to be catching an
> > odd usage of of_device_make_bus_id(). Why is of_device_make_bus_id()
> > being called on i2c devices? Those shouldn't be modelled as
> > platform_devices.
>
> Sorry, this was my explanation being full of crap. It's my i2c
> _controller_ which is a platform device, and is on the xscom bus which
> isn't directly MMIO translatable.
Okay, that makes more sense, but if xscom is a different bus with
different access methods, then why is it using platform_bus_type? I
would expect it to have it's own bus_type and container for struct
device.
> The patch still stands :)
Indeed, I merged it yesterday. :)
>
> Cheers,
> Ben.
>
> > g.
> >
> > >
> > > Turn this into a pr_debug instead
> > >
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > >
> > > diff --git a/drivers/of/address.c b/drivers/of/address.c
> > > index f0541fd..bf1f79d 100644
> > > --- a/drivers/of/address.c
> > > +++ b/drivers/of/address.c
> > > @@ -444,7 +444,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
> > > */
> > > ranges = of_get_property(parent, rprop, &rlen);
> > > if (ranges == NULL && !of_empty_ranges_quirk()) {
> > > - pr_err("OF: no ranges; cannot translate\n");
> > > + pr_debug("OF: no ranges; cannot translate\n");
> > > return 1;
> > > }
> > > if (ranges == NULL || rlen == 0) {
> > >
> > >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
>
next prev parent reply other threads:[~2014-11-19 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 6:58 [PATCH] of/address: Don't throw errors on absent ranges properties Benjamin Herrenschmidt
2014-11-18 16:57 ` Grant Likely
2014-11-19 2:32 ` Benjamin Herrenschmidt
2014-11-19 10:31 ` Grant Likely [this message]
2014-11-20 23:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119103140.2B9F4C40551@trevor.secretlab.ca \
--to=grant.likely@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).