From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755334AbaKSKxQ (ORCPT ); Wed, 19 Nov 2014 05:53:16 -0500 Received: from mail.skyhub.de ([78.46.96.112]:51850 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbaKSKxP (ORCPT ); Wed, 19 Nov 2014 05:53:15 -0500 Date: Wed, 19 Nov 2014 11:53:11 +0100 From: Borislav Petkov To: Jiri Kosina Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , Andrew Morton , Petr Mladek , "Paul E. McKenney" , Andy Lutomirski , Tony Luck Subject: Re: [RFC][PATCH 3/3] x86/nmi: Perform a safe NMI stack trace on all CPUs Message-ID: <20141119105311.GB5617@pd.tnic> References: <20141119043917.578498291@goodmis.org> <20141119045556.084787418@goodmis.org> <20141119104114.GA5684@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 19, 2014 at 11:44:56AM +0100, Jiri Kosina wrote: > If we are going down this path, do_nmi() should be early enough to do > it, no need to pollute NMI assembly code with this. do_nmi() doesn't cover all, like do_machine_check(), do_double_fault(), and the rest of the handlers. I'm suggesting to do it before any handler gets run so that you can use printk in the handler itself. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --