From: Steven Rostedt <rostedt@goodmis.org>
To: "pang.xunlei" <pang.xunlei@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@gmail.com>
Subject: Re: [PATCH v2 3/4] sched/deadline: add the "set_flag" argument to cpudl_find()
Date: Wed, 19 Nov 2014 11:24:51 -0500 [thread overview]
Message-ID: <20141119112451.6fef30f0@gandalf.local.home> (raw)
In-Reply-To: <1416411982-1204-3-git-send-email-pang.xunlei@linaro.org>
On Wed, 19 Nov 2014 23:46:21 +0800
"pang.xunlei" <pang.xunlei@linaro.org> wrote:
> The call site of cpudl_find() in check_preempt_equal_dl() doesn't
> use later_mask, so add this extra argument to distinquish the case.
>
> Signed-off-by: pang.xunlei <pang.xunlei@linaro.org>
> ---
> kernel/sched/cpudeadline.c | 6 ++++--
> kernel/sched/cpudeadline.h | 2 +-
> kernel/sched/deadline.c | 6 +++---
> 3 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
> index c01b3aa..3047846 100644
> --- a/kernel/sched/cpudeadline.c
> +++ b/kernel/sched/cpudeadline.c
> @@ -98,11 +98,12 @@ static inline int cpudl_maximum(struct cpudl *cp)
> * @cp: the cpudl max-heap context
> * @p: the task
> * @later_mask: a mask to fill in with the selected CPUs (not NULL)
> + * @set_flag: indicate if later_mask should be set
> *
> * Returns: int - best CPU (heap maximum if suitable)
> */
> int cpudl_find(struct cpudl *cp, struct task_struct *p,
> - struct cpumask *later_mask)
> + struct cpumask *later_mask, int set_flag)
set_flag should be a bool type.
> {
> int best_cpu = -1;
> const struct sched_dl_entity *dl_se = &p->dl;
> @@ -114,7 +115,8 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p,
> } else if (cpumask_test_cpu(cpudl_maximum(cp), &p->cpus_allowed) &&
> dl_time_before(dl_se->deadline, cp->elements[0].dl)) {
> best_cpu = cpudl_maximum(cp);
> - cpumask_set_cpu(best_cpu, later_mask);
> + if (set_flag)
> + cpumask_set_cpu(best_cpu, later_mask);
I'm not sure this is worth it. cpumask_set_cpu() is rather efficient.
> }
>
> out:
next prev parent reply other threads:[~2014-11-19 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 15:46 [PATCH v2 1/4] sched/deadline: Modify cpudl.free_cpus to reflect rd->span pang.xunlei
2014-11-19 15:46 ` [PATCH v2 2/4] sched/deadline: Fix wrong cpudl_find() in check_preempt_equal_dl() pang.xunlei
2014-11-19 15:46 ` [PATCH v2 3/4] sched/deadline: add the "set_flag" argument to cpudl_find() pang.xunlei
2014-11-19 16:24 ` Steven Rostedt [this message]
2014-11-20 14:58 ` pang.xunlei
2014-11-20 15:06 ` pang.xunlei
2014-11-19 15:46 ` [PATCH v2 4/4] sched/deadline: change cpudl_find() to return bool instead of best_cpu pang.xunlei
2014-11-19 16:30 ` Steven Rostedt
2014-11-20 9:00 ` [PATCH v2 1/4] sched/deadline: Modify cpudl.free_cpus to reflect rd->span Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119112451.6fef30f0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).