From: NeilBrown <neilb@suse.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chris Ball <chris@printf.net>, Balaji T K <balajitk@ti.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
GTA04 owners <gta04-owner@goldelico.com>,
Venkatraman S <svenkatr@ti.com>, Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality
Date: Thu, 20 Nov 2014 08:44:31 +1100 [thread overview]
Message-ID: <20141120084431.7a2220bc@notabene.brown> (raw)
In-Reply-To: <CAPDyKFr=vjh5UOzkrbn7Fpm8j97sqf6xxD7tm+HydOKtyeYKoQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2456 bytes --]
On Wed, 19 Nov 2014 11:14:24 +0100 Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 8 November 2014 00:52, NeilBrown <neilb@suse.de> wrote:
> > omap_hsmmc currently duplicates some work that can be done for
> > it by common code, and consequently does not benefit from extra
> > functionality in that common code.
> >
> > In particular, mmc_of_parse and the slot-gpio library are not used.
> >
> > This set of patches allows omap_hsmmc to use that common
> > functionality, and benefit from any extra devicetree parsing
> > that it performs.
> >
> > The one awkward part of this change is that omap_hsmmc has an
> > interrupt handler for 'card detect' which does more than the
> > common code.
> > I see three options:
> > 1 - move that functionality into common code
> > 2 - discard that functionality
> > 3 - allow the common code to be configured to use a device-specific
> > card detect interrupt.
> >
> > This series implements '3'. I suspect a mix of '1' and '2' would
> > be a better choice but I know no of the history or justification
> > for those differences.
> >
> > My preference would be for this series to be applied (if there are
> > no other issues) and if there are opinions about effecting '1' or '2',
> > they can be done with subsequent patches.
> >
> > Thanks,
> > NeilBrown
> >
>
> I like the looks of this patchset, but it needs a rebase.
Thanks. What should I rebase against? Is 3.18-rc sufficient or is there
some other tree I should work against?
Thanks,
NeilBrown
>
> Kind regards
> Uffe
>
> >
> > ---
> >
> > NeilBrown (3):
> > mmc: omap_hsmmc: remove prepare/complete system suspend support.
> > mmc: omap_hsmmc: use slot-gpio library for gpio support.
> > mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration.
> >
> >
> > drivers/mmc/core/slot-gpio.c | 21 ++++
> > drivers/mmc/host/omap_hsmmc.c | 158 +++++---------------------------
> > include/linux/mmc/slot-gpio.h | 2
> > include/linux/platform_data/mmc-omap.h | 4 -
> > 4 files changed, 47 insertions(+), 138 deletions(-)
> >
> > --
> > Signature
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2014-11-19 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 23:52 [PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality NeilBrown
2014-11-07 23:52 ` [PATCH 2/3] mmc: omap_hsmmc: use slot-gpio library for gpio support NeilBrown
2014-11-07 23:52 ` [PATCH 3/3] mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration NeilBrown
2014-11-07 23:52 ` [PATCH 1/3] mmc: omap_hsmmc: remove prepare/complete system suspend support NeilBrown
2014-11-19 10:14 ` [PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality Ulf Hansson
2014-11-19 21:44 ` NeilBrown [this message]
2014-11-21 12:56 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120084431.7a2220bc@notabene.brown \
--to=neilb@suse.de \
--cc=balajitk@ti.com \
--cc=balbi@ti.com \
--cc=chris@printf.net \
--cc=gta04-owner@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=svenkatr@ti.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).