From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756647AbaKTOjp (ORCPT ); Thu, 20 Nov 2014 09:39:45 -0500 Received: from helcar.apana.org.au ([209.40.204.226]:52309 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753977AbaKTOjn (ORCPT ); Thu, 20 Nov 2014 09:39:43 -0500 Date: Thu, 20 Nov 2014 22:39:32 +0800 From: Herbert Xu To: SF Markus Elfring Cc: "David S. Miller" , linux-crypto@vger.kernel.org, Linux Kernel Mailing List , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/1] crypto-drbg: Deletion of unnecessary checks before the function call "kzfree" Message-ID: <20141120143932.GA31996@gondor.apana.org.au> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546C60E0.1070903@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546C60E0.1070903@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 19, 2014 at 10:20:32AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Nov 2014 10:11:04 +0100 > > The kzfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Sorry but you're too late as someone else has already fixed this :) Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt