From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jiri Kosina <jkosina@suse.cz>,
Seth Jennings <sjenning@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Petr Mladek <pmladek@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
Namhyung Kim <namhyung@kernel.org>,
Miroslav Benes <mbenes@suse.cz>, Ingo Molnar <mingo@kernel.org>
Subject: [PATCH ftrace/core v6 0/5] ftrace, kprobes: Introduce IPMODIFY flag for ftrace_ops to detect conflicts
Date: Fri, 21 Nov 2014 05:25:02 -0500 [thread overview]
Message-ID: <20141121102502.11844.82696.stgit@localhost.localdomain> (raw)
Hi,
Here is the 6th version of the series of patches which introduces
IPMODIFY flag for ftrace_ops to detect conflicts of ftrace users
who can modify regs->ip in their handler.
This version is basically an update of previous version to the
latest ftrace/core tree.
Currently, only kprobes can change the regs->ip in the handler,
but recent Kernel Live Patching also changes it.
Here we talked on github.
https://github.com/dynup/kpatch/issues/47
To protect modified regs-ip from each other, this series
introduces FTRACE_OPS_FL_IPMODIFY flag and ftrace now ensures
the flag can be set on each function entry location. If there
is someone who already reserve regs->ip on target function
entry, ftrace_set_filter_ip or register_ftrace_function will
return -EBUSY. Users must handle that.
The ftrace_ops with IPMODIFY flag requires at least one
entry for filter hash, and its notrace_hash must be empty,
because the IPMODIFY action is very address sensitve and
user must consider the ip address.
Thank you,
---
Masami Hiramatsu (5):
kprobes/ftrace: Recover original IP if pre_handler doesn't change it
ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict
kprobes: Add IPMODIFY flag to kprobe_ftrace_ops
kprobes: Set IPMODIFY flag only if the probe can change regs->ip
kselftest,ftrace: Add ftrace IPMODIFY flag test
Documentation/kprobes.txt | 12 +
Documentation/trace/ftrace.txt | 5 +
arch/x86/kernel/kprobes/ftrace.c | 9 +
include/linux/ftrace.h | 16 ++
kernel/kprobes.c | 123 +++++++++++++-
kernel/trace/ftrace.c | 142 ++++++++++++++++-
tools/testing/selftests/ftrace/Makefile | 11 +
tools/testing/selftests/ftrace/ipmodify/Makefile | 15 ++
tools/testing/selftests/ftrace/ipmodify/ipmodify.c | 170 ++++++++++++++++++++
.../selftests/ftrace/ipmodify/run_ipmodify.sh | 6 +
10 files changed, 480 insertions(+), 29 deletions(-)
create mode 100644 tools/testing/selftests/ftrace/ipmodify/Makefile
create mode 100644 tools/testing/selftests/ftrace/ipmodify/ipmodify.c
create mode 100644 tools/testing/selftests/ftrace/ipmodify/run_ipmodify.sh
--
next reply other threads:[~2014-11-21 2:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 10:25 Masami Hiramatsu [this message]
2014-11-21 10:25 ` [PATCH ftrace/core v6 1/5] kprobes/ftrace: Recover original IP if pre_handler doesn't change it Masami Hiramatsu
2014-11-21 10:25 ` [PATCH ftrace/core v6 2/5] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict Masami Hiramatsu
2014-11-21 18:05 ` Steven Rostedt
2014-11-21 19:43 ` Steven Rostedt
2014-11-24 2:12 ` Masami Hiramatsu
2014-11-24 2:06 ` Masami Hiramatsu
2014-11-21 10:25 ` [PATCH ftrace/core v6 3/5] kprobes: Add IPMODIFY flag to kprobe_ftrace_ops Masami Hiramatsu
2014-11-21 10:25 ` [PATCH ftrace/core v6 4/5] kprobes: Set IPMODIFY flag only if the probe can change regs->ip Masami Hiramatsu
2014-11-21 20:15 ` Steven Rostedt
2014-11-24 2:43 ` Masami Hiramatsu
2015-01-26 16:14 ` Petr Mladek
2015-02-24 7:38 ` Masami Hiramatsu
2015-02-24 8:52 ` Petr Mladek
2015-02-24 11:47 ` Masami Hiramatsu
2015-02-24 13:10 ` Petr Mladek
2014-11-21 10:25 ` [PATCH ftrace/core v6 5/5] kselftest, ftrace: Add ftrace IPMODIFY flag test Masami Hiramatsu
2014-11-21 21:03 ` Steven Rostedt
2014-11-24 2:50 ` Masami Hiramatsu
2014-11-24 4:29 ` Steven Rostedt
2014-11-24 14:11 ` Masami Hiramatsu
2014-11-24 15:07 ` Steven Rostedt
2014-11-24 15:18 ` Steven Rostedt
2014-11-24 15:19 ` Steven Rostedt
2014-11-25 1:51 ` Masami Hiramatsu
2014-11-24 16:18 ` Shuah Khan
2014-11-25 1:23 ` Masami Hiramatsu
2014-11-25 14:42 ` Shuah Khan
2014-11-25 14:44 ` Shuah Khan
2014-11-26 7:20 ` Masami Hiramatsu
2014-11-26 18:40 ` Shuah Khan
2014-11-27 4:56 ` Masami Hiramatsu
2014-11-26 14:31 ` Steven Rostedt
2014-11-27 0:55 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121102502.11844.82696.stgit@localhost.localdomain \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).