From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751139AbaKVJoj (ORCPT ); Sat, 22 Nov 2014 04:44:39 -0500 Received: from mail.skyhub.de ([78.46.96.112]:58571 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbaKVJog (ORCPT ); Sat, 22 Nov 2014 04:44:36 -0500 Date: Sat, 22 Nov 2014 10:44:33 +0100 From: Borislav Petkov To: rui wang Cc: "Luck, Tony" , "linux-kernel@vger.kernel.org" , "gong.chen@linux.intel.com" , "Wang, Rui Y" Subject: Re: [PATCH v3] x86/mce: Try printing all machine check banks known before panic Message-ID: <20141122094433.GA12152@pd.tnic> References: <1416388961-24159-1-git-send-email-ruiv.wang@gmail.com> <20141119102954.GA5617@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F3294198E@ORSMSX114.amr.corp.intel.com> <20141120101505.GA791@pd.tnic> <20141121164140.GA4274@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F3294F888@ORSMSX114.amr.corp.intel.com> <20141121181334.GC4274@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 22, 2014 at 10:16:49AM +0800, rui wang wrote: > I think both possibilities are valid. But experiments show that the > error logs are not in the dmesg preserved by kdump in /var/crash/ > after panic and reboot, and not in the mcelog.entry[] array in the > kernel. So they must be somewhere in user space memory. Even if we > have serial console connected we still can't cache them. The > difficulty is that there's no easy way to force a user space daemon to > do something during panic. > > The new banks_saved[] array acts like a safe guard when you pass > something to someone else - to prevent it from getting lost in the > interim. ... and instead of duplicating the mcelog functionality partially by adding yet another array of struct mces, simply change mcelog to not zero out its contents and dump the last 32 errors that passed through there. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --