From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753902AbaKXPsr (ORCPT <rfc822;w@1wt.eu>);
	Mon, 24 Nov 2014 10:48:47 -0500
Received: from mail.kernel.org ([198.145.19.201]:51118 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752915AbaKXPsp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 24 Nov 2014 10:48:45 -0500
Date: Mon, 24 Nov 2014 12:48:41 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Namhyung Kim <namhyung.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: perf/branch-history branch build broken with NO_DEMANGLE=1 perf
 hists browser: Print overhead percent value for first-level callchain
Message-ID: <20141124154841.GD13167@kernel.org>
References: <20141124145227.GE18625@kernel.org>
 <20141124152312.GA13167@kernel.org>
 <20141124152541.GB13167@kernel.org>
 <20141124153204.GC13167@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20141124153204.GC13167@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Nov 24, 2014 at 12:32:04PM -0300, Arnaldo Carvalho de Melo escreveu:
> >        ^
> > In file included from util/srcline.c:11:0:
> > util/symbol.h:35:21: note: previous definition of ‘bfd_demangle’ was
> > here
> >  static inline char *bfd_demangle(void __maybe_unused *v,
> >                      ^
> > make[1]: *** [util/srcline.o] Error 1
> > make: *** [util/srcline.o] Error 2
> > make: Leaving directory `/home/git/linux/tools/perf'
> > [acme@zoo linux]$ 
> 
> bisected it down to:

What I have is on the perf/branch-history branch, we can't both include
bfd.h and symbol.h when NO_DEMANGLE=1, probably we should just move the
stub inline to symbol-elf.c, its only user, but I have to check further,
lunch time tho.

- Arnaldo
 
> 43e3229ef07a2dda81bda86a5b81ef8c2890ab63 is the first bad commit
> commit 43e3229ef07a2dda81bda86a5b81ef8c2890ab63
> Author: Andi Kleen <ak@linux.intel.com>
> Date:   Wed Nov 12 18:05:27 2014 -0800
> 
>     perf callchain: Make get_srcline fall back to sym+offset
>     
>     When the source line is not found fall back to sym + offset.  This is
>     generally much more useful than a raw address.
>     
>     For this we need to pass in the symbol from the caller.
>     
>     For some callers it's awkward to compute, so we stay at the old
>     behaviour.
>     
>     Signed-off-by: Andi Kleen <ak@linux.intel.com>
>     Cc: Jiri Olsa <jolsa@redhat.com>
>     Cc: Namhyung Kim <namhyung@kernel.org>
>     Link: http://lkml.kernel.org/r/1415844328-4884-10-git-send-email-andi@firstfloor.org
>     Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> :040000 040000 ae5e95c8dbfd9ab8e836707fcb2904e263f872c6
> 5979ba316f1d317c59866b0c3bf92c39fbdcde6b M	tools
> [acme@zoo linux]$