From: Gyungoh Yoo <gyungoh@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: sameo@linux.intel.com, jg1.han@samsung.com, cooloney@gmail.com,
broonie@kernel.org, lgirdwood@gmail.com,
jack.yoo@skyworksinc.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, grant.likely@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
pawel.moll@arm.com, heiko@sntech.de, jason@lakedaemon.net,
shawn.guo@freescale.com, treding@nvidia.com,
florian.vaussard@epfl.ch, trivial@kernel.org, linux@roeck-us.net,
andrew@lunn.ch, jic23@kernel.org
Subject: Re: [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding
Date: Tue, 25 Nov 2014 10:47:49 +0900 [thread overview]
Message-ID: <20141125014749.GA28978@jack-ThinkPad-T520> (raw)
In-Reply-To: <20141117122333.GQ24004@x1>
On Mon, Nov 17, 2014 at 12:23:33PM +0000, Lee Jones wrote:
> On Mon, 17 Nov 2014, gyungoh@gmail.com wrote:
>
> > From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> >
> > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> > ---
> > Changes v7:
> > Nothing
> >
> > Changes v6:
> > Nothing
> >
> > Changes v5:
> > Nothing
> >
> > Changes v4:
> > Nothing
> >
> > Changes v3:
> > Nothing
> >
> > Changes v2:
> > Added reg attribute for I2C slave address
> >
> > .../video/backlight/sky81452-backlight.txt | 24 ++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> >
> > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> > new file mode 100644
> > index 0000000..2c2d947
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> > @@ -0,0 +1,24 @@
> > +SKY81452-backlight bindings
> > +
> > +Required properties:
> > +- compatible : Must be "skyworks,sky81452-backlight"
> > +
> > +Optional properties:
> > +- name : Name of backlight device. Default is 'lcd-backlight'.
> > +- gpio-enable : GPIO to use to EN pin.
> > +- enable : Enable mask for current sink channel 1 to 6.
> > +- ignore-pwm : Ignore both PWM input
> > +- dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming mode
> > +- phase-shift : Enable phase shift mode
> > +- ovp-level : Over-voltage protection level. Should be between 14 or 28V.
> > +- short-detection-threshold : It should be one of 4, 5, 6 and 7V.
> > +- boost-current-limit : It should be one of 800, 1100 and 1500mA.
>
> These are going to need some serious reviewing from the DT guys. Each
> property should either have a vendor prefix or be made generic and
> placed in the generic DT documentation for the subsystem. The name
> 'enable' is far to generic we don't tend to put masks in DT. There
> is already a generic property for GPIO enable pins.
I see. I will rename the properties with the vendor prefix
and modify the name for GPIO enable pin to use 'gpios'
>
> > +Example:
> > +
> > + backlight {
> > + compatible = "skyworks,sky81452-backlight";
> > + name = "pwm-backlight";
> > + enable = <0x3F>;
>
> Lower case.
>
> > + ignore-pwm;
>
> You should probably demonstrate more of your properties here.
I will make up the example.
Thank you for your comments.
>
> > + };
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-11-25 1:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 8:33 [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 1/9] mfd: Add support for Skyworks SKY81452 driver gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 2/9] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 3/9] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 4/9] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-11-17 12:23 ` Lee Jones
2014-11-25 1:47 ` Gyungoh Yoo [this message]
2014-11-17 8:33 ` [RESUBMIT PATCH v7 5/9] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 6/9] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure gyungoh
2014-11-17 14:18 ` Mark Brown
2014-11-18 8:04 ` Gyungoh Yoo
2014-11-18 11:20 ` Mark Brown
2014-11-19 7:39 ` Gyungoh Yoo
2014-11-19 10:14 ` Mark Brown
2014-11-17 8:33 ` [RESUBMIT PATCH v7 8/9] devicetree: " gyungoh
2014-11-17 8:33 ` [RESUBMIT PATCH v7 9/9] regulator: sky81452: Modify dependent Kconfig symbol gyungoh
2014-11-17 14:19 ` Mark Brown
2014-11-17 13:37 ` [RESUBMIT PATCH v7 0/9] Add Skyworks SKY81452 device drivers Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125014749.GA28978@jack-ThinkPad-T520 \
--to=gyungoh@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jack.yoo@skyworksinc.com \
--cc=jason@lakedaemon.net \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@freescale.com \
--cc=treding@nvidia.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).