From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751797AbaKYUjA (ORCPT ); Tue, 25 Nov 2014 15:39:00 -0500 Received: from mail-qg0-f51.google.com ([209.85.192.51]:34035 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbaKYUi6 (ORCPT ); Tue, 25 Nov 2014 15:38:58 -0500 Date: Tue, 25 Nov 2014 16:38:47 -0400 From: Eduardo Valentin To: Lukasz Majewski Cc: Zhang Rui , Linux PM list , Thierry Reding , Bartlomiej Zolnierkiewicz , Lukasz Majewski , Mikko Perttunen , Stephen Warren , Abhilash Kesavan , Abhilash Kesavan , Guenter Roeck , linux-kernel@vger.kernel.org, Caesar Wang Subject: Re: [PATCH v2 3/4] thermal: of: Extend of-thermal to export table of trip points Message-ID: <20141125203845.GB14292@developer> References: <1412872737-624-1-git-send-email-l.majewski@samsung.com> <1416500488-7232-1-git-send-email-l.majewski@samsung.com> <1416500488-7232-4-git-send-email-l.majewski@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="K8nIJk4ghYZn606h" Content-Disposition: inline In-Reply-To: <1416500488-7232-4-git-send-email-l.majewski@samsung.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --K8nIJk4ghYZn606h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 20, 2014 at 05:21:27PM +0100, Lukasz Majewski wrote: > This patch extends the of-thermal.c to export copy of trip points for > a given thermal zone. >=20 > Thermal drivers should use of_thermal_get_trip_points() method to get > pointer to table of thermal trip points. >=20 > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - New patch - as suggested by Eduardo Valentin > --- > drivers/thermal/of-thermal.c | 33 +++++++++++++++++++++++++++++++++ > drivers/thermal/thermal_core.h | 7 +++++++ > include/linux/thermal.h | 14 ++++++++++++++ > 3 files changed, 54 insertions(+) >=20 > diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c > index 336af7f..33921c5 100644 > --- a/drivers/thermal/of-thermal.c > +++ b/drivers/thermal/of-thermal.c > @@ -89,6 +89,7 @@ struct __thermal_zone { > /* trip data */ > int ntrips; > struct __thermal_trip *trips; > + struct thermal_trip *gtrips; > =20 > /* cooling binding data */ > int num_tbps; > @@ -152,6 +153,27 @@ bool of_thermal_is_trip_en(struct thermal_zone_devic= e *tz, int trip) > return true; > } > =20 > +/** > + * of_thermal_get_trip_points - function to get access to a globally exp= orted > + * trip points > + * > + * @tz: pointer to a thermal zone > + * > + * This function provides a pointer to the copy of trip points table > + * > + * Return: pointer to trip points table, NULL otherwise > + */ > +const struct thermal_trip * const > +of_thermal_get_trip_points(struct thermal_zone_device *tz) Another thing, can you please check why scripts/kernel-doc does not like this prototype? It throws an warn: Warning(drivers/thermal/of-thermal.c:168): cannot understand function prototype: 'const struct thermal_trip * const of_thermal_get_trip_points(struct thermal_zone_device *tz) ' > +{ > + struct __thermal_zone *data =3D tz->devdata; > + > + if (!data) > + return NULL; > + > + return data->gtrips; > +} > + > static int of_thermal_get_trend(struct thermal_zone_device *tz, int trip, > enum thermal_trend *trend) > { > @@ -767,6 +789,16 @@ thermal_of_build_thermal_zone(struct device_node *np) > goto free_tbps; > } > =20 > + tz->gtrips =3D kcalloc(tz->ntrips, sizeof(*tz->gtrips), GFP_KERNEL); > + if (!tz->gtrips) { > + ret =3D -ENOMEM; > + goto free_tbps; > + } > + > + for (i =3D 0; i < tz->ntrips; i++) > + memcpy(&(tz->gtrips[i]), &(tz->trips[i].temperature), > + sizeof(*tz->gtrips)); > + > finish: > of_node_put(child); > tz->mode =3D THERMAL_DEVICE_DISABLED; > @@ -793,6 +825,7 @@ static inline void of_thermal_free_zone(struct __ther= mal_zone *tz) > { > int i; > =20 > + kfree(tz->gtrips); > for (i =3D 0; i < tz->num_tbps; i++) > of_node_put(tz->tbps[i].cooling_device); > kfree(tz->tbps); > diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_cor= e.h > index 466208c..a9580ca 100644 > --- a/drivers/thermal/thermal_core.h > +++ b/drivers/thermal/thermal_core.h > @@ -91,6 +91,8 @@ int of_parse_thermal_zones(void); > void of_thermal_destroy_zones(void); > int of_thermal_get_ntrips(struct thermal_zone_device *); > bool of_thermal_is_trip_en(struct thermal_zone_device *, int); > +const struct thermal_trip * const > +of_thermal_get_trip_points(struct thermal_zone_device *); > #else > static inline int of_parse_thermal_zones(void) { return 0; } > static inline void of_thermal_destroy_zones(void) { } > @@ -102,6 +104,11 @@ static inline bool of_thermal_is_trip_en(struct ther= mal_zone_device *, int) > { > return 0; > } > +static inline const struct thermal_trip * const > +of_thermal_get_trip_points(struct thermal_zone_device *) > +{ > + return NULL; > +} > #endif > =20 > #endif /* __THERMAL_CORE_H__ */ > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index 5bc28a7..88d7249 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -303,6 +303,20 @@ struct thermal_zone_of_device_ops { > int (*get_trend)(void *, long *); > }; > =20 > +/** > + * struct thermal_trip - Structure representing themal trip points expor= ted from > + * of-thermal > + * > + * @temperature: trip point temperature > + * @hysteresis: trip point hysteresis > + * @type: trip point type > + */ > +struct thermal_trip { > + unsigned long int temperature; > + unsigned long int hysteresis; > + enum thermal_trip_type type; > +}; > + > /* Function declarations */ > #ifdef CONFIG_THERMAL_OF > struct thermal_zone_device * > --=20 > 2.0.0.rc2 >=20 --K8nIJk4ghYZn606h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUdOjMAAoJEMLUO4d9pOJWxbAH/izuIdWp33DbP5Rj5hg+mVau u2omjJFwFFuyy2KQMo46pi9WSKzZ4RL0qcp0JGQfUDabhDJhOW0fhgwbdk3Wntxd S2NIIZEuWolYAwQdSUQ3R1ys5VJ250zRi0yR10f+WdGnJRDqie7dnR46lEmwaiza bQ9Y/SgL+UGQvX9UcXzoZGNqDIGRENktw6KcPLDBPuoJIUYpnVPNcQP9JVsoQWeO 5E4DSYMDFYatP6idIrobIaNPXx5t+GTWOE6HnPqzdMWiLMJtCvEyTO09qaVR70ka 3QHC+aSE4D18NrI3GFumS373fk3iKE2UX/lPWgv2RV1ysLyY8yFvhmgAjqvGnwY= =u5UC -----END PGP SIGNATURE----- --K8nIJk4ghYZn606h--