From: Greg KH <gregkh@linuxfoundation.org>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: linux-kernel@vger.kernel.org, eunb.song@samsung.com,
gulsah.1004@gmail.com, paul.gortmaker@windriver.com,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: octeon: Fix checkpatch warning
Date: Wed, 26 Nov 2014 13:45:23 -0800 [thread overview]
Message-ID: <20141126214523.GA10037@kroah.com> (raw)
In-Reply-To: <20141125132614.GA23857@biggie>
On Tue, Nov 25, 2014 at 01:26:14PM +0000, Luis de Bethencourt wrote:
> This patch fixes the checkpatch.pl warnings:
>
> WARNING: line over 80 characters
> + int cores_in_use = core_state.baseline_cores - atomic_read(&core_state.available_cores);
>
> WARNING: line over 80 characters
> + skb->data = skb->head + work->packet_ptr.s.addr - cvmx_ptr_to_phys(skb->head);
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
> drivers/staging/octeon/ethernet-rx.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
> index 44e372f..bd83f55 100644
> --- a/drivers/staging/octeon/ethernet-rx.c
> +++ b/drivers/staging/octeon/ethernet-rx.c
> @@ -295,7 +295,8 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
> */
> union cvmx_pow_wq_int_cntx counts;
> int backlog;
> - int cores_in_use = core_state.baseline_cores - atomic_read(&core_state.available_cores);
> + int cores_in_use = core_state.baseline_cores -
> + atomic_read(&core_state.available_cores);
> counts.u64 = cvmx_read_csr(CVMX_POW_WQ_INT_CNTX(pow_receive_group));
> backlog = counts.s.iq_cnt + counts.s.ds_cnt;
> if (backlog > budget * cores_in_use && napi != NULL)
> @@ -324,7 +325,8 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
> * buffer.
> */
> if (likely(skb_in_hw)) {
> - skb->data = skb->head + work->packet_ptr.s.addr - cvmx_ptr_to_phys(skb->head);
> + skb->data = skb->head + work->packet_ptr.s.addr -
> + cvmx_ptr_to_phys(skb->head);
> prefetch(skb->data);
> skb->len = work->len;
> skb_set_tail_pointer(skb, skb->len);
> --
> 2.1.3
No longer applies to my tree :(
next prev parent reply other threads:[~2014-11-26 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 13:26 [PATCH] staging: octeon: Fix checkpatch warning Luis de Bethencourt
2014-11-26 21:45 ` Greg KH [this message]
2014-11-27 0:35 ` Luis de Bethencourt
2014-11-27 2:34 ` Greg KH
2014-11-27 15:18 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126214523.GA10037@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=eunb.song@samsung.com \
--cc=gulsah.1004@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).