From: Eduardo Valentin <edubezval@gmail.com>
To: Navneet Kumar <navneetk@nvidia.com>
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Diwakar Tundlam <dtundlam@nvidia.com>
Subject: Re: [PATCH 1/3] thermal: of: support writable trips via dt
Date: Thu, 27 Nov 2014 10:21:29 -0400 [thread overview]
Message-ID: <20141127142127.GB3342@developer> (raw)
In-Reply-To: <1417050989-25405-1-git-send-email-navneetk@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2656 bytes --]
Hello Navneet
On Wed, Nov 26, 2014 at 05:16:27PM -0800, Navneet Kumar wrote:
> From: navneet kumar <navneetk@nvidia.com>
>
> Support writable trip points configuration from the
> device tree. 'OF' reads this configuration and adjusts
> the 'trips' mask accordingly to allow the 'set_trip_xxx'
> calls to be effective.
>
> Signed-off-by: Diwakar Tundlam <dtundlam@nvidia.com>
Thanks for sharing your patches!
> ---
> drivers/thermal/of-thermal.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 62143ba31001..cf9ee3e82fee 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -604,7 +604,8 @@ static int thermal_of_get_trip_type(struct device_node *np,
> * Return: 0 on success, proper error code otherwise
> */
> static int thermal_of_populate_trip(struct device_node *np,
> - struct __thermal_trip *trip)
> + struct __thermal_trip *trip,
> + bool *trip_writable)
> {
> int prop;
> int ret;
> @@ -629,6 +630,8 @@ static int thermal_of_populate_trip(struct device_node *np,
> return ret;
> }
>
> + *trip_writable = of_property_read_bool(np, "writable");
New DT properties needs to be properly discussed in device tree mainling
list. From what I see here, this property does not describe hardware,
does it?
A simple git grep writable Documentation/devicetree/bindings/
returns nothing. So, I am a bit skeptic having this property is
allowable.
In any case, can you please send your proposal also copying device tree mailing list?
devicetree@vger.kernel.org
Besides, you need to document this new property:
Documentation/devicetree/bindings/thermal/thermal.txt
All the best,
Eduardo Valentin
> +
> /* Required for cooling map matching */
> trip->np = np;
> of_node_get(np);
> @@ -657,6 +660,8 @@ thermal_of_build_thermal_zone(struct device_node *np)
> struct __thermal_zone *tz;
> int ret, i;
> u32 prop;
> + bool trip_writable;
> + u64 m = 0;
>
> if (!np) {
> pr_err("no thermal zone np\n");
> @@ -700,9 +705,14 @@ thermal_of_build_thermal_zone(struct device_node *np)
>
> i = 0;
> for_each_child_of_node(child, gchild) {
> - ret = thermal_of_populate_trip(gchild, &tz->trips[i++]);
> + trip_writable = false;
> + ret = thermal_of_populate_trip(gchild, &tz->trips[i],
> + &trip_writable);
> if (ret)
> goto free_trips;
> + if (trip_writable)
> + m |= 1ULL << i;
> + i++;
> }
>
> of_node_put(child);
> --
> 1.8.1.5
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-11-27 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 1:16 [PATCH 1/3] thermal: of: support writable trips via dt Navneet Kumar
2014-11-27 1:16 ` [PATCH 2/3] thermal: of: consolidate sensor callbacks as ops Navneet Kumar
2014-11-27 14:28 ` Eduardo Valentin
2014-12-01 19:29 ` navneet kumar
2014-11-27 1:16 ` [PATCH 3/3] thermal: of: notify sensor driver on trip updates Navneet Kumar
2014-11-27 14:32 ` Eduardo Valentin
2014-12-01 20:45 ` navneet kumar
2014-12-01 21:23 ` Eduardo Valentin
2014-12-01 22:35 ` navneet kumar
2014-11-27 14:21 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127142127.GB3342@developer \
--to=edubezval@gmail.com \
--cc=dtundlam@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=navneetk@nvidia.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).