Re: [PATCH 1/2] ASoC: rt5677: Add ACPI device probing

From: Mark Brown <broonie@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Darren Hart <dvhart@linux.intel.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Ben Zhang <benzh@chromium.org>,
	alsa-devel <alsa-devel@alsa-project.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Anatol Pomozov <anatol@google.com>,
	Dylan Reid <dgreid@chromium.org>,
	flove@realtek.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: rt5677: Add ACPI device probing
Date: Fri, 28 Nov 2014 16:00:36 +0000	[thread overview]
Message-ID: <20141128160036.GW7712@sirena.org.uk> (raw)
In-Reply-To: <7202604.4LK4s7RH1S@vostro.rjw.lan>

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

On Thu, Nov 27, 2014 at 12:09:55AM +0100, Rafael J. Wysocki wrote:
> On Wednesday, November 26, 2014 11:17:16 AM Mark Brown wrote:

> > > As to registering ACPI IDs, I believe this is the right link:
> > > http://www.uefi.org/PNP_ACPI_Registry

> > No, those are vendors as far as I can tell.  I mean identifiers for
> > specific devices - it appears to be common for for example Intel to
> > allocate identifiers for devices they don't produce, I'd expect there to
> > be some effort to keep track of that especially given that _DSD
> > properties may well end up being specific to the identifier used to
> > register in cases of parallel evolution.

> The vendor (or more precisely the owner of the initial 3 or 4 letter code)
> is supposed to do that.  I'm not aware of any common registry of those IDs
> for all vendors.

OK, we probably should have one to aid discoverability since as far as I
can tell what's happening is that people (hi Intel!) are allocating
their own identifiers for devices produced by other vendors that turn up
on their boards.  If people can find the set of IDs in use there's more
chance they'll use the same ones as other people.

> > > Or did you mean a HID/CID<->DSD mapping?

> > I don't really know what that is, sorry.

> The device ID is supposed to determine the way all of the ACPI objects for that
> device will work, including what is returned by _DSD.  Pretty much in analogy
> with PCI device IDs.

So the HID and CID are device IDs then?  Please bear in mind that we're
not all familiar with the acronym soup that tends to go along with ACPI!

If those are device IDs then what you're saying is what I'd expect to
happen and it's part of the reason I'd expect us to be registering IDs
along with registering properties - if people are defining device
specific properties they really ought to be tied to the IDs that are in
use especially if (as seems likely to be the case with the current state
of the world) people are doing things without attempting to coordinate
and we're ending up trying to document the deployed reality.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]