From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbaLBN4o (ORCPT ); Tue, 2 Dec 2014 08:56:44 -0500 Received: from tex.lwn.net ([70.33.254.29]:59821 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbaLBN4m (ORCPT ); Tue, 2 Dec 2014 08:56:42 -0500 Date: Tue, 2 Dec 2014 08:56:39 -0500 From: Jonathan Corbet To: Julia Lawall Cc: Dan Carpenter , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, OGAWA Hirofumi , SF Markus Elfring , Coccinelle Subject: Re: [patch] CodingStyle: add some more error handling guidelines Message-ID: <20141202085639.43080af0@lwn.net> In-Reply-To: References: <20141202085950.GA13434@mwanda> Organization: LWN.net X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.24; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Dec 2014 10:09:02 +0100 (CET) Julia Lawall wrote: > kmalloc actually takes two arguments. Perhaps it would be better to show > something that looks like a valid call. Agreed; I took the liberty of sticking in a GFP_KERNEL as I applied the patch with Julia's ack. Thanks, jon