On Wed, Dec 03, 2014 at 03:18:38PM +0800, Jianqun Xu wrote: > From: Sonny Rao > > We need to claim the clock which is driving the codec so that when we enable > clock gating, we continue to clock the codec when needed. I make this an > optional clock since there might be some applications where we don't need it > but can still use the I2S block. I would expect that the clock for the CODEC should be managed by the CODEC if at all possible - that seems more logical than having the CPU I2S controller request and manage it if it's a separate clock. Why add this to the CPU side driver? We've not always done this for older systems due to the lack of a usable clock API but that's starting to be addressed.