From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbaLITyz (ORCPT ); Tue, 9 Dec 2014 14:54:55 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:38093 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbaLITyw (ORCPT ); Tue, 9 Dec 2014 14:54:52 -0500 Date: Tue, 09 Dec 2014 14:54:47 -0500 (EST) Message-Id: <20141209.145447.2234157264287438778.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: sergei.shtylyov@cogentembedded.com, paulus@samba.org, linux-ppp@vger.kernel.org, netdev@vger.kernel.org, eric.dumazet@gmail.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks From: David Miller In-Reply-To: <5480DA32.8000201@users.sourceforge.net> References: <547C82A6.2030808@users.sourceforge.net> <547CA157.1080401@cogentembedded.com> <5480DA32.8000201@users.sourceforge.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 09 Dec 2014 11:54:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Thu, 04 Dec 2014 23:03:30 +0100 > From: Markus Elfring > Date: Thu, 4 Dec 2014 22:50:28 +0100 > > Further update suggestions were taken into account before and after a patch > was applied from static source code analysis. Generally speaking, it is advisable to not leave error pointers in data structures, even if they are about to be free'd up in an error path anyways. Therefore I do not like some of the patches in this series. Sorry.