From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758534AbaLKAHA (ORCPT ); Wed, 10 Dec 2014 19:07:00 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:38316 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758299AbaLKAG6 (ORCPT ); Wed, 10 Dec 2014 19:06:58 -0500 Date: Wed, 10 Dec 2014 17:06:54 -0700 From: Bjorn Helgaas To: SF Markus Elfring Cc: Scott Murray , linux-pci@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/1] PCI: hotplug: Deletion of an unnecessary check before the function call "pci_dev_put" Message-ID: <20141211000654.GB22886@google.com> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546E1B21.2070206@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <546E1B21.2070206@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 20, 2014 at 05:47:29PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 20 Nov 2014 17:42:23 +0100 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied to next-pci/misc for v3.19, thanks. This branch will be rebased when v3.19-rc1 is released. Bjorn > --- > drivers/pci/hotplug/cpci_hotplug_core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pci/hotplug/cpci_hotplug_core.c b/drivers/pci/hotplug/cpci_hotplug_core.c > index e09cf78..82c969b 100644 > --- a/drivers/pci/hotplug/cpci_hotplug_core.c > +++ b/drivers/pci/hotplug/cpci_hotplug_core.c > @@ -211,8 +211,7 @@ static void release_slot(struct hotplug_slot *hotplug_slot) > > kfree(slot->hotplug_slot->info); > kfree(slot->hotplug_slot); > - if (slot->dev) > - pci_dev_put(slot->dev); > + pci_dev_put(slot->dev); > kfree(slot); > } > > -- > 2.1.3 >