From: Dave Chinner <email@example.com>
To: David Drysdale <firstname.lastname@example.org>
Cc: "email@example.com" <firstname.lastname@example.org>,
Alexander Viro <email@example.com>,
Kees Cook <firstname.lastname@example.org>,
"Eric W. Biederman" <email@example.com>,
Greg Kroah-Hartman <firstname.lastname@example.org>,
Meredydd Luff <email@example.com>,
Will Drewry <firstname.lastname@example.org>,
Jorge Lucangeli Obes <email@example.com>,
Ricky Zhou <firstname.lastname@example.org>, Lee Campbell <email@example.com>,
Julien Tinnes <firstname.lastname@example.org>,
Mike Depinet <email@example.com>,
James Morris <firstname.lastname@example.org>,
Andy Lutomirski <email@example.com>,
Paolo Bonzini <firstname.lastname@example.org>,
Paul Moore <email@example.com>,
Christoph Hellwig <firstname.lastname@example.org>,
Linux API <email@example.com>,
LSM List <firstname.lastname@example.org>,
Subject: Re: [PATCHv2 2/3] selftests: Add test of O_BENEATH & openat(2)
Date: Fri, 12 Dec 2014 11:05:25 +1100 [thread overview]
Message-ID: <20141212000524.GI24183@dastard> (raw)
On Fri, Nov 21, 2014 at 02:19:41PM +0000, David Drysdale wrote:
> On Tue, Nov 11, 2014 at 5:36 AM, Dave Chinner <email@example.com> wrote:
> > [cc firstname.lastname@example.org]
> > On Tue, Nov 04, 2014 at 09:54:43AM +0000, David Drysdale wrote:
> >> Add simple tests of openat(2) variations, including examples that
> >> check the new O_BENEATH flag.
> >> Signed-off-by: David Drysdale <email@example.com>
> > Wouldn't this be better added to fstests? That's the regression
> > test suite used by filesystem developers and most distro QA
> > organisations and where the fs developers aggregate all their new
> > regression tests.
> > IMO, the fewer places we aggregate VFS/filesystem tests the better.
> > I really don't think the kernel tree is the best place for adding
> > VFS behavioural tests because it has none of the infrastructure
> > around it to test arbitrary filesystems and configurations and hence
> > is not particularly useful to the people whoa re likely to notice
> > and care about fs regression tests suddenly breaking.
> > As an example, the recent renameat() syscall additions (e.g.
> > RENAME_EXCHANGE, RENAME_NOREPLACE) have unit tests in fstests, so
> > these new O_BENEATH tests should really follow the same model...
> Fair enough, that makes sense -- I've now got a version of the selftest
> running within xfstests (git://oss.sgi.com/xfs/cmds/xfstests.git is the
> master repo, right?).
Or git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git, which is
where I typically update first and push dev branches to.
> Given that xfstests is independent of the kernel, what's the expected
> way to deal with flags (or syscalls) that are only in specific kernel
> versions? At the moment I've just got a primitive override at
> compile time (#ifndef O_BENEATH #define O_BENEATH ...), and
> then the test will fail at run-time against an older kernel -- is there a
> need for anything more sophisticated? (And if so, are there any
> examples I can crib from?)
See the code in the src/renameat2.c for an example of how syscalls
and their flags are added prior to their being kernel and userspace
Also, note the "-t" CLI option for the "test" option in that little
program. This is used by the _require_renameat2 function that the
tests that make use of this functionality call to determine if th
etest shoul dbe run on this kernel or not.
> Also, is there an archive of the fstests@ mailing list somewhere?
I wish. I've tried to get it archived on all the major sites like
marc, spinics, etc repeatedly since the list was created and not a
single one of them have responded to any of my requests, let alone
started to archive the list....
next prev parent reply other threads:[~2014-12-12 0:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 9:54 [PATCHv2 0/3] fs: add O_BENEATH flag to openat(2) David Drysdale
2014-11-04 9:54 ` [PATCHv2 1/3] " David Drysdale
2014-11-04 9:54 ` [PATCHv2 2/3] selftests: Add test of O_BENEATH & openat(2) David Drysdale
2014-11-04 18:47 ` Kees Cook
2014-11-11 5:36 ` Dave Chinner
2014-11-21 14:19 ` David Drysdale
2014-12-12 0:05 ` Dave Chinner [this message]
2014-11-04 9:54 ` [PATCHv2 man-pages 3/3] open.2: describe O_BENEATH flag David Drysdale
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).