From: Jeremiah Mahler <jmmahler@gmail.com>
To: Aapo Vienamo <aapo.vienamo@iki.fi>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix redundant parens in return in amplc_dio200_common.c
Date: Thu, 18 Dec 2014 14:45:01 -0800 [thread overview]
Message-ID: <20141218224501.GC6742@hudson.localdomain> (raw)
In-Reply-To: <1418916772-24778-1-git-send-email-aapo.vienamo@iki.fi>
Aapo,
On Thu, Dec 18, 2014 at 05:32:52PM +0200, Aapo Vienamo wrote:
> This patch fixes a coding style issue found by the checkpatch.pl tool in
> amplc_dio200_common.c by removing the unnecessary parentheses around the
> expression in a return statement.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
> ---
> drivers/staging/comedi/drivers/amplc_dio200_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/amplc_dio200_common.c b/drivers/staging/comedi/drivers/amplc_dio200_common.c
> index 26aad70..6eadbbe 100644
> --- a/drivers/staging/comedi/drivers/amplc_dio200_common.c
> +++ b/drivers/staging/comedi/drivers/amplc_dio200_common.c
> @@ -340,7 +340,7 @@ static int dio200_handle_read_intr(struct comedi_device *dev,
>
> comedi_handle_events(dev, s);
>
> - return (triggered != 0);
> + return triggered != 0;
> }
>
[...]
When I run checkpatch.pl it doesn't find any errors and the parenthesis
haven't been removed. How are you running checkpatch.pl? Are you using
any extra options?
--
- Jeremiah Mahler
next prev parent reply other threads:[~2014-12-18 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 15:32 [PATCH] Staging: comedi: fix redundant parens in return in amplc_dio200_common.c Aapo Vienamo
2014-12-18 22:45 ` Jeremiah Mahler [this message]
2014-12-19 10:37 ` Aapo Vienamo
2014-12-19 14:13 ` Jeremiah Mahler
2014-12-19 21:07 ` Aapo Vienamo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218224501.GC6742@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=aapo.vienamo@iki.fi \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).