From: Luis Henriques <luis.henriques@canonical.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-usb@vger.kernel.org, ronald.wahl@raritan.com,
stable@vger.kernel.org, Kamal Mostafa <kamal@canonical.com>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context
Date: Fri, 19 Dec 2014 13:51:23 +0000 [thread overview]
Message-ID: <20141219135123.GA2620@charon> (raw)
In-Reply-To: <20141120195049.GF23217@saruman>
Hi Felipe,
On Thu, Nov 20, 2014 at 01:50:49PM -0600, Felipe Balbi wrote:
> On Wed, Nov 19, 2014 at 04:37:27PM +0100, Nicolas Ferre wrote:
> > From: Ronald Wahl <ronald.wahl@raritan.com>
> >
> > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b (usb: gadget: at91_udc:
> > prepare clk before calling enable) added clock preparation in interrupt
> > context. This is not allowed as it might sleep. Also setting the clock
> > rate is unsafe to call from there for the same reason. Move clock
> > preparation and setting clock rate into process context (at91udc_probe).
> >
> > Signed-off-by: Ronald Wahl <ronald.wahl@raritan.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Cc: Felipe Balbi <balbi@ti.com>
> > Cc: <stable@vger.kernel.org> # v3.17+
> > ---
> > Hi Felipe,
> >
> > I forgot to answer you on this patch. So I resend it now with the proper
> > "stable" tag. You can also queue it during this -rc phase if you feel it is
> > still possible.
>
> I think it's late for v3.18, so it'll go on v3.19 and get backported to
> 3.17 and 3.18. Sorry :-s
>
Although this commit (b2ba27a5c56f "usb: gadget: at91_udc: move
prepare clk into process context") is tagged for stable v3.17+, it
seems like it could be applied to earlier kernels.
3.16, 3.13 and 3.12 seem to be affected by the same issue (and they
all include commit 7628083227b6 "usb: gadget: at91_udc: prepare clk
before calling enable"). Is there any reason for not applying it in
these trees?
Cheers,
--
Luís
> cheers
>
> --
> balbi
next prev parent reply other threads:[~2014-12-19 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 15:37 [RESEND PATCH] usb: gadget: at91_udc: move prepare clk into process context Nicolas Ferre
2014-11-20 19:50 ` Felipe Balbi
2014-12-19 13:51 ` Luis Henriques [this message]
2014-12-19 14:02 ` Ronald Wahl
2014-12-19 14:08 ` Nicolas Ferre
2014-12-19 14:18 ` Luis Henriques
2014-12-22 16:43 ` Felipe Balbi
2015-01-13 18:32 ` Kamal Mostafa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219135123.GA2620@charon \
--to=luis.henriques@canonical.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=balbi@ti.com \
--cc=boris.brezillon@free-electrons.com \
--cc=jslaby@suse.cz \
--cc=kamal@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=ronald.wahl@raritan.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).