From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dudley Du <dudl@cypress.com>
Cc: Jeremiah Mahler <jmmahler@gmail.com>,
"rydberg@euromail.se" <rydberg@euromail.se>,
"bleung@google.com" <bleung@google.com>,
David Solda <dso@cypress.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v16 00/12] input: cyapa: instruction of cyapa patches
Date: Sun, 21 Dec 2014 18:39:59 -0800 [thread overview]
Message-ID: <20141222023959.GA30082@dtor-ws> (raw)
In-Reply-To: <BN1PR06MB0701C428956C2E7F7A1DD76D1560@BN1PR06MB070.namprd06.prod.outlook.com>
Hi Dudley,
On Mon, Dec 22, 2014 at 02:09:36AM +0000, Dudley Du wrote:
> Thanks, Dmitry and Jeremiah,
>
> I reproduced this issue in my side when putting fingers on trackpad when system booting up.
> It only happened on gen3 trackpad device.
> The root cause is, for gen3 TP, the cyapa->ops->sort_empty_output_data is not set, so when cyapa->input is not set,
> the interrupt process should be passed, but since the logica error, it's not, so this issue happen.
>
> The fix code should be as below.
> I will correct it and resubmited the patches.
Please hold off resubmitting the patches just yet, let me go over the
last version you posted.
Thanks!
--
Dmitry
next prev parent reply other threads:[~2014-12-22 2:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 10:00 [PATCH v16 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-18 10:00 ` [PATCH v16 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver Dudley Du
2014-12-30 1:06 ` Dmitry Torokhov
2014-12-30 4:43 ` Dudley Du
2014-12-18 10:00 ` [PATCH v16 02/12] input: cyapa: add gen5 trackpad device basic functions support Dudley Du
2014-12-18 10:00 ` [PATCH v16 03/12] input: cyapa: add power management interfaces support for the device Dudley Du
2014-12-30 0:51 ` Dmitry Torokhov
2014-12-18 10:00 ` [PATCH v16 04/12] input: cyapa: add runtime " Dudley Du
2014-12-30 0:57 ` Dmitry Torokhov
2014-12-18 10:00 ` [PATCH v16 05/12] input: cyapa: add sysfs interfaces support in the cyapa driver Dudley Du
2014-12-18 10:00 ` [PATCH v16 06/12] input: cyapa: add gen3 trackpad device firmware update function support Dudley Du
2014-12-18 10:00 ` [PATCH v16 07/12] input: cyapa: add gen3 trackpad device read baseline " Dudley Du
2014-12-18 10:00 ` [PATCH v16 08/12] input: cyapa: add gen3 trackpad device force re-calibrate " Dudley Du
2014-12-18 10:00 ` [PATCH v16 09/12] input: cyapa: add gen5 trackpad device firmware update " Dudley Du
2014-12-18 10:00 ` [PATCH v16 10/12] input: cyapa: add gen5 trackpad device read baseline " Dudley Du
2014-12-18 10:00 ` [PATCH v16 11/12] input: cyapa: add gen5 trackpad device force re-calibrate " Dudley Du
2014-12-18 10:00 ` [PATCH v16 12/12] input: cyapa: add acpi device id support Dudley Du
2014-12-18 11:06 ` [PATCH v16 00/12] input: cyapa: instruction of cyapa patches Dudley Du
2014-12-18 20:17 ` Benson Leung
2014-12-18 22:14 ` Jeremiah Mahler
2014-12-19 1:45 ` Dudley Du
2014-12-20 7:15 ` Jeremiah Mahler
2014-12-20 7:31 ` Dmitry Torokhov
2014-12-22 2:09 ` Dudley Du
2014-12-22 2:39 ` Dmitry Torokhov [this message]
2014-12-22 2:56 ` Dudley Du
-- strict thread matches above, loose matches on Subject: below --
2014-12-17 9:55 Dudley Du
2014-12-17 10:03 ` Dudley Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222023959.GA30082@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@google.com \
--cc=dso@cypress.com \
--cc=dudl@cypress.com \
--cc=jmmahler@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).