From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073AbaLVHMW (ORCPT ); Mon, 22 Dec 2014 02:12:22 -0500 Received: from mail-pd0-f174.google.com ([209.85.192.174]:37171 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754035AbaLVHMU (ORCPT ); Mon, 22 Dec 2014 02:12:20 -0500 Date: Sun, 21 Dec 2014 23:12:16 -0800 From: Omar Sandoval To: Al Viro Cc: Andrew Morton , Trond Myklebust , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Ming Lei Subject: Re: [PATCH v2 2/5] direct-io: don't dirty ITER_BVEC pages on read Message-ID: <20141222071216.GA24722@mew> References: <20141220060130.GA22149@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141220060130.GA22149@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 20, 2014 at 06:01:30AM +0000, Al Viro wrote: > On Fri, Dec 19, 2014 at 07:18:26PM -0800, Omar Sandoval wrote: > > Reads through the iov_iter infrastructure for kernel pages shouldn't be > > dirtied by the direct I/O code. > > > > This is based on Dave Kleikamp's and Ming Lei's previously posted > > patches. > > Umm... > > > + dio->should_dirty = !iov_iter_is_bvec(iter); > > dio->should_dirty = iter_is_iovec(iter); > > perhaps? Mm, yeah, I'll do that. That helper snuck in without me noticing it... I see that we can't do iov_iter_get_pages on an ITER_KVEC, so a kvec doesn't work for blockdev_direct_IO anyways, right? -- Omar