From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, acme@kernel.org
Subject: Re: [PATCH] tools: lib: traceevent: event-parse.c: Remove some unused functions
Date: Mon, 22 Dec 2014 16:07:07 +0100 [thread overview]
Message-ID: <20141222150707.GE29096@krava.brq.redhat.com> (raw)
In-Reply-To: <20141222145210.GA2188@redhat.com>
On Mon, Dec 22, 2014 at 12:52:10PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Sat, Dec 20, 2014 at 01:45:41PM +0100, Rickard Strandqvist escreveu:
> > Removes some functions that are not used anywhere:
> > pevent_get_any_field_val() pevent_get_common_field_val() pevent_event_fields() pevent_event_common_fields() pevent_list_events() pevent_print_event() pevent_data_event_from_type() pevent_register_trace_clock() pevent_pid_is_registered()
> >
> > This was partially found by using a static code analysis program called cppcheck.
>
> Steven, Namhyung, Jiri:
>
> Are you ok with me applying this patch? I'm all for it, dead code better
> be removed, but I don't know what are your plans wrt synchronization
> with the trace-cmd repo.
I'm not aware about more porting from traceevent lib, but I'm
guessing there's still lot of things missing..?
However, if we go with the removal, this patch has same
issue as the other one.. missing removal of functions
used only in removed code:
CC FPIC event-parse.o
/home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/event-parse.c:4597:13: warning: ‘is_timestamp_in_us’ defined but not used [-Wunused-function]
static bool is_timestamp_in_us(char *trace_clock, bool use_trace_clock)
^
/home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/event-parse.c:4624:12: warning: ‘events_name_cmp’ defined but not used [-Wunused-function]
static int events_name_cmp(const void *a, const void *b)
^
/home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/event-parse.c:4641:12: warning: ‘events_system_cmp’ defined but not used [-Wunused-function]
static int events_system_cmp(const void *a, const void *b)
^
/home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/event-parse.c:4659:1: warning: ‘get_event_fields’ defined but not used [-Wunused-function]
get_event_fields(const char *type, const char *name,
^
CC FPIC event-plugin.o
thanks,
jirka
next prev parent reply other threads:[~2014-12-22 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 12:45 [PATCH] tools: lib: traceevent: event-parse.c: Remove some unused functions Rickard Strandqvist
2014-12-22 14:52 ` Arnaldo Carvalho de Melo
2014-12-22 15:07 ` Jiri Olsa [this message]
2014-12-22 22:00 ` Rickard Strandqvist
2014-12-23 3:14 ` Namhyung Kim
2014-12-23 13:28 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222150707.GE29096@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).