From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564AbcGSUEi (ORCPT ); Tue, 19 Jul 2016 16:04:38 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:64827 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751364AbcGSUEh (ORCPT ); Tue, 19 Jul 2016 16:04:37 -0400 From: "Rafael J. Wysocki" To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org Subject: Re: [PATCH] ACPI / PMIC: remove modular references from non-modular code Date: Tue, 19 Jul 2016 22:09:30 +0200 Message-ID: <2014296.Y0F3yzq3m9@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160711220516.3371-1-paul.gortmaker@windriver.com> References: <20160711220516.3371-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 11, 2016 06:05:16 PM Paul Gortmaker wrote: > The Kconfig currently controlling compilation of these files are: > > drivers/acpi/Kconfig:menuconfig PMIC_OPREGION > drivers/acpi/Kconfig: bool "PMIC (Power Management Integrated Circuit) operation region support" > > drivers/acpi/Kconfig:config BXT_WC_PMIC_OPREGION > drivers/acpi/Kconfig: bool "ACPI operation region support for BXT WhiskeyCove PMIC" > > drivers/acpi/Kconfig:config XPOWER_PMIC_OPREGION > drivers/acpi/Kconfig: bool "ACPI operation region support for XPower AXP288 PMIC" > > ...meaning they currently are not being built as a module by anyone. > > Lets remove the couple traces of modular infrastructure use, so that > when reading the code there is no doubt it is builtin-only. > > We delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > One file was using module_init. Since module_init translates to > device_initcall in the non-modular case, the init ordering remains > unchanged with this commit. > > In one case we replace the module.h with export.h since that file > is exporting some symbols, but does not use __init. The other two > are using __init and so module.h gets replaced with init.h there. > > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: linux-acpi@vger.kernel.org > Signed-off-by: Paul Gortmaker Applied, thanks!