linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>,
	Mike Turquette <mturquette@linaro.org>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	linux-tegra@vger.kernel.org,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	mikko.perttunen@kapsi.fi, acourbot@nvidia.com,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Prashant Gaikwad <pgaikwad@nvidia.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 12/14] clk: tegra: Add EMC clock driver
Date: Mon, 5 Jan 2015 14:59:13 +0100	[thread overview]
Message-ID: <20150105135912.GB12010@ulmo.nvidia.com> (raw)
In-Reply-To: <20150102162750.GA10073@tbergstrom-lnx.Nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

On Fri, Jan 02, 2015 at 06:27:50PM +0200, Peter De Schrijver wrote:
> On Tue, Nov 18, 2014 at 01:13:14PM +0100, Tomeu Vizoso wrote:
> > From: Mikko Perttunen <mperttunen@nvidia.com>
> > 
> > The driver is currently only tested on Tegra124 Jetson TK1, but should
> > work with other Tegra124 boards, provided that correct EMC tables are
> > provided through the device tree. Older chip models have differing
> > timing change sequences, so they are not currently supported.
> > 
> > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> > 
> > ---
> > 
> > v5:	* Get a pointer to the EMC driver at runtime, to be used when
> > 	  calling the EMC API.
> > 	* Misc. style fixes
> > 	* Fix logic for rounding down to a high rate
> > 
> > v4:	* Adapt to changes in the OF bindings
> > 	* Improve error handling
> > 	* Fix comment style
> > 	* Make static a few more functions
> > 
> > v3:	* Add some locking to protect the registers that are shared with the MC
> > 	  clock
> > 
> > v2:	* Make sure that the clock is properly registered
> > 	* Bail out early from attempts to set the same rate
> 
> Thierry,
> 
> How do you want to merge this series? The clock tree part depends on
> tegra_read_ram_code which is introduced earlier in this series.

I guess the easiest would be to take this all into the Tegra tree. Apart
from patches 1, 12 and 14 everything would go via that anyway. I'll also
take some time this week to give the series some review, I don't think I
have looked at this code at all yet.

Mike, you "looks good to me"'d patches 1, 12 and 14, does that translate
to an Acked-by?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-01-05 13:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 12:13 [PATCH v5 00/14] Tegra124 EMC (external memory controller) support Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 01/14] clk: tegra124: Remove old emc clock Tomeu Vizoso
2014-11-18 21:23   ` Mike Turquette
2014-11-18 12:13 ` [PATCH v5 02/14] of: Document long-ram-code property in nvidia,tegra20-apbmisc Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 03/14] soc/tegra: Add ram code reader helper Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 04/14] of: document new emc-timings subnode in nvidia,tegra124-car Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 05/14] of: Document timings subnode of nvidia,tegra-mc Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 06/14] of: Add Tegra124 EMC bindings Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 07/14] of: document external-memory-controller property in tegra124-car Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 08/14] ARM: tegra: Add EMC to Tegra124 device tree Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 09/14] ARM: tegra: Add EMC timings to Jetson TK1 " Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 10/14] memory: tegra: Add API needed by the EMC driver Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 11/14] memory: tegra: Add EMC (external memory controller) driver Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 12/14] clk: tegra: Add EMC clock driver Tomeu Vizoso
2014-11-18 21:33   ` Mike Turquette
2014-11-19 15:29   ` Nikolaus Schulz
2015-01-02 16:27   ` Peter De Schrijver
2015-01-05 13:59     ` Thierry Reding [this message]
2015-03-12  9:30       ` Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 13/14] memory: tegra: Add debugfs entry for getting and setting the EMC rate Tomeu Vizoso
2014-11-18 12:13 ` [PATCH v5 14/14] clk: tegra: Set the EMC clock as the parent of the MC clock Tomeu Vizoso
2014-11-18 21:35   ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105135912.GB12010@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mikko.perttunen@kapsi.fi \
    --cc=mperttunen@nvidia.com \
    --cc=mturquette@linaro.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).